Skip to content

Add some basic rules for ruff linter and black formatting#660

Merged
acolomb merged 2 commits intocanopen-python:masterfrom
acolomb:black-ruff
May 7, 2026
Merged

Add some basic rules for ruff linter and black formatting#660
acolomb merged 2 commits intocanopen-python:masterfrom
acolomb:black-ruff

Conversation

@acolomb
Copy link
Copy Markdown
Member

@acolomb acolomb commented May 7, 2026

Line-length 96 is a compomise because 80 is problematic with existing
code, but we want a bit of headroom for the next common limit of 100.

String "normalization" is complete noise in most cases, that could be
enabled again after some general cleanup.

Make sure that ruff agrees with the previously used import ordering
style from isort.

The last change is extracted from #644.

acolomb added 2 commits May 7, 2026 09:47
Line-length 96 is a compomise because 80 is problematic with existing
code, but we want a bit of headroom for the next common limit of 100.

String "normalization" is complete noise in most cases, that could be
enabled again after some general cleanup.
Make sure that ruff agrees with the previously used import ordering
style from isort.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@acolomb acolomb merged commit 35f4b7f into canopen-python:master May 7, 2026
4 of 5 checks passed
@acolomb
Copy link
Copy Markdown
Member Author

acolomb commented May 7, 2026

I guess this should help a bit with the disturbances encountered in #644 and #658. I still want a more gradual approach to reformatting and style adjustments. Feature work and fixes are definitely top priority, and we can get back to code style issues when the backlog has been reduced.

@acolomb acolomb deleted the black-ruff branch May 7, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant