Memorized DOMAIN ObjectType for a proper export#655
Open
FedericoSpada wants to merge 1 commit intocanopen-python:masterfrom
Open
Memorized DOMAIN ObjectType for a proper export#655FedericoSpada wants to merge 1 commit intocanopen-python:masterfrom
FedericoSpada wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Changed to save whether a Variable has ObjectType==DOMAIN while importing an EDS, so that it is possible to export it unchanged.
bizfsc
approved these changes
May 5, 2026
Contributor
bizfsc
left a comment
bizfsc
left a comment
There was a problem hiding this comment.
Looking good. As far as I can check it, no new problems introduced for mypy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with an EDS that had DOMAIN objects, I've noted that when imported and exported using this library, all DOMAIN Objects were converted to normal Variables.
While importing an EDS, I've changed to save whether a Variable was created from an object with
ObjectType==DOMAIN. In this way, it is possible to export it unchanged with the proper ObjectType value.