Expose mknodat/mkfifoat on Apple targets#1625
Open
mattsu2020 wants to merge 3 commits into
Open
Conversation
macOS 13 added mknodat/mkfifoat system calls. Use the same weak-linking pattern as linkat/unlinkat/renameat: resolve the symbol at runtime via dlsym, and fall back to mknod/mkfifo when the symbol is unavailable and dirfd == AT_FDCWD.
macOS 13 and earlier are EOL. Use c::mknodat directly via libc without weak-linking, matching other platforms.
The use declarations for Dev and FileType were gated with cfg(not(apple)), causing compilation failures when mknodat became available on Apple. Remove apple from the exclusion list.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustix::fs::{mknodat, mkfifoat}on Apple targets, which were previously gated out withcfg(not(apple))mknodat/mkfifoatsystem calls;mkfifoatworks automatically as it delegates tomknodat