uucore: remove unsafe make_fifo#12243
Merged
Merged
Conversation
oech3
force-pushed
the
makefifo
branch
2 times, most recently
from
9c35983 to
7ee1124
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
May 11, 2026
| fs_extra = { workspace = true } | ||
| indicatif = { workspace = true } | ||
| libc = { workspace = true } | ||
| nix = { workspace = true } |
Contributor
There was a problem hiding this comment.
as we discussed earlier, I would like to avoid having rustix, libc and nix.
can we avoid this here? thanks
Contributor
Author
There was a problem hiding this comment.
rustix::fs::mkfifoat is missing macos and redox support currently.
I can use it for SELinux specific *.rs.
Contributor
Author
There was a problem hiding this comment.
It seems libc is used just for const. Ith might be able to remove one.
Contributor
Author
There was a problem hiding this comment.
Contributor
|
|
xtqqczze
reviewed
May 16, 2026
| // Create a FIFO (pipe) | ||
| let fifo_path = dir_path.join("my_fifo"); | ||
| crate::fs::make_fifo(&fifo_path).expect("Failed to create FIFO"); | ||
| // todo: use rustix::fs::mkfifoat since selinux is linux specific |
Contributor
There was a problem hiding this comment.
Yeah, rustix::fs::mkfifoat would be best. However, since tempfile::TempDir does not provide a handle to the directory, it's not feasible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11249 (comment)