Skip to content

Conversation

@kpreid
Copy link
Contributor

@kpreid kpreid commented Sep 13, 2025

Another cleanup that is technically a breaking change. The struct was completely unused inside the crate and unusable outside.

An alternative to this PR would be to use Vec<Color> in place of the returned Vec<u8>, but that would require several more impls to be really usable.

Copy link
Owner

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let me know if you have any more breaking changes on the way, I was close to publishing 0.2 on crates.io but I'll hold off for a bit if there are more changes we want to make soon.

@bschwind bschwind merged commit b770558 into bschwind:main Sep 13, 2025
3 checks passed
@kpreid
Copy link
Contributor Author

kpreid commented Sep 13, 2025

I have one more in mind — what do you think of making the return type be Vec<[u8; 4]> so that it is statically proven to be a multiple of 4 bytes, but still flexible? (Users wanting Vec<u8> can use Vec::into_flattened() to get that.)

I won’t be doing any more PRs today, though — time for me to sleep.

@kpreid kpreid deleted the color branch September 13, 2025 04:01
@bschwind
Copy link
Owner

I have one more in mind — what do you think of making the return type be Vec<[u8; 4]> so that it is statically proven to be a multiple of 4 bytes, but still flexible?

I think that makes sense, but let me think it through a bit before we go with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants