Make decode() produce Vec<[u8; 4]> instead of Vec<u8>.
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has identical memory layout, but guarantees that the output will always be a multiple of 4 bytes long and allows the caller to easily manipulate whole pixels.
Contributor
Author
|
Thank you! Since we were previously discussing planning breaking changes, I’ll say that this was the last breaking change I had in mind and, for my own purposes, I’d be happy if you were to make a release now. |
Owner
|
@kpreid sounds good, I'll try to cut a new release soon. |
Owner
|
@kpreid sorry for the wait, version 0.2 is published now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
decode()produceVec<[u8; 4]>instead ofVec<u8>. This has identical memory layout, but guarantees that the output will always be a multiple of 4 bytes long and allows the caller to easily manipulate whole pixels. If they want the original type, they can callVec::into_flattened()to obtain it for free.Also, add documentation to
decode().