Skip to content

ci(msrv): add ./ci/pin-msrv.sh #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamuAbba wants to merge 2 commits into from
Closed

ci(msrv): add ./ci/pin-msrv.sh #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
985d3e6
ci(msrv): add `./ci/pin-msrv.sh`
AdamuAbba Feb 9, 2026
de4eaa9
chore(docs): update `README` with steps to run just MSRV recipe
AdamuAbba Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/cont_integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,7 @@ jobs:
run: rustup update
- name: Pin dependencies for MSRV
if: matrix.rust.version == '1.75.0'
run: |
cargo update -p minreq --precise "2.13.2"
cargo update -p idna_adapter --precise "1.2.0"
cargo update -p native-tls --precise "0.2.13"
cargo update -p zerofrom --precise "0.1.5"
cargo update -p litemap --precise "0.7.4"
run: ./ci/pin-msrv.sh
- name: Build
run: cargo build --features ${{ matrix.features }} --no-default-features
- name: Test
Expand Down
10 changes: 1 addition & 9 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,4 @@ Bitcoin Esplora API client library. Supports plaintext, TLS and Onion servers. B

This library should compile with any combination of features with Rust 1.75.0.

To build with the MSRV you will need to pin dependencies as follows:

```shell
cargo update -p minreq --precise "2.13.2"
cargo update -p idna_adapter --precise "1.2.0"
cargo update -p native-tls --precise "0.2.13"
cargo update -p zerofrom --precise "0.1.5"
cargo update -p litemap --precise "0.7.4"
```
To build with the MSRV of 1.75.0 you may need to pin dependencies by running the [`pin-msrv.sh`](./ci/pin-msrv.sh) script.
18 changes: 18 additions & 0 deletions ci/pin-msrv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env bash

set -x
set -euo pipefail

# Pin dependencies for MSRV

# To pin deps, switch toolchain to MSRV and execute the below updates

# cargo clean
# rustup override set 1.75.0

cargo update -p minreq --precise "2.13.2"
cargo update -p home --precise "0.5.9"
cargo update -p native-tls --precise "0.2.13"
cargo update -p idna_adapter --precise "1.2.0"
cargo update -p zerofrom --precise "0.1.5"
cargo update -p litemap --precise "0.7.4"
5 changes: 5 additions & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ alias c := check
alias f := fmt
alias t := test
alias p := pre-push
alias m := msrv

_default:
@just --list
Expand Down Expand Up @@ -31,3 +32,7 @@ test:

# Run pre-push suite: format, check, and test
pre-push: fmt check test

# set the rust version to the msrv and pin dependencies
Copy link
Collaborator

@oleonardolima oleonardolima Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the pin-msrv.sh is not setting the rust version to 1.75.0.

Copy link
Author

@AdamuAbba AdamuAbba Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oleonardolima thanks for taking time to review this. So I wanted to ask you what route to take on this? I can either uncomment the line that sets the rust version to 1.75.0 in pin-msrv.sh or leave it be and just update the comment here to express that it just pins the dependencies.

msrv:
./ci/pin-msrv.sh