ci(msrv): add ./ci/pin-msrv.sh#169
Closed
AdamuAbba wants to merge 2 commits intobitcoindevkit:masterfrom
Closed
Conversation
| # Run pre-push suite: format, check, and test | ||
| pre-push: fmt check test | ||
|
|
||
| # set the rust version to the msrv and pin dependencies |
Collaborator
There was a problem hiding this comment.
nit: the pin-msrv.sh is not setting the rust version to 1.75.0.
Author
There was a problem hiding this comment.
Hey @oleonardolima thanks for taking time to review this. So I wanted to ask you what route to take on this? I can either uncomment the line that sets the rust version to 1.75.0 in pin-msrv.sh or leave it be and just update the comment here to express that it just pins the dependencies.
- ci: update the MSRV job to run `./ci/pin-msrv` script. - update `justfile` with MSRV recipe Signed-off-by: shytypes <abbaadamu302@gmail.com>
Signed-off-by: shytypes <abbaadamu302@gmail.com>
Collaborator
|
@AdamuAbba Thanks for working on this one, however as @luisschwab opened the initial issue it've been superseded by #172, feel free to cotinue working on other issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #165
Description
Commit - 2d14589:
./ci/pin-msrvscriptjustfilewith an MSRV recipeCommit - 2ba1274:
READMEwith instruction to run the MSRV just recipe@luisschwab saw you had assigned this to yourself 2 weeks ago hope you wouldn't mind me taking some work off your hands?. Also I wasn't sure if it would be better to have the doc change in the same commit so I went with separate commits. Let me know if I missed anything and I'll reiterate, thank you.