Skip to content

Retain upscaling pipeline#22918

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
IceSentry:upscaling_cache_pipeline
Feb 24, 2026
Merged

Retain upscaling pipeline#22918
alice-i-cecile merged 2 commits intobevyengine:mainfrom
IceSentry:upscaling_cache_pipeline

Conversation

@IceSentry
Copy link
Copy Markdown
Contributor

@IceSentry IceSentry commented Feb 12, 2026

Objective

  • On most frames the upscaling pipeline doesn't change but this code was made before the retained render world and inserted a new one every frame

Solution

  • Retain the upscaling pipeline and only update it if necessary

Testing

  • I tested the split_screen example and things still work as expected

Notes

Realistically, the performance difference will be minimal since all the heavy work is already cached but that still allows us to skip a couple of validation steps and a blocking function.

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 12, 2026
@cart cart added this to Rendering Feb 12, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Feb 12, 2026
@cart cart removed this from Rendering Feb 12, 2026
Copy link
Copy Markdown
Contributor

@Smerom Smerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lack knowledge of the rendering pipeline, but the code looks correct.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 23, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Feb 23, 2026
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Feb 23, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 23, 2026
Merged via the queue into bevyengine:main with commit 1273812 Feb 24, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants