Skip to content

feat: show navbar immediately while metadata.json loads #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meyer9 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −4
Open

feat: show navbar immediately while metadata.json loads #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions report/src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ const Navbar = ({ urlPrefix }: ProvidedProps) => {
</Link>
</div>
</div>
{!isLoadTestsRoute && isLoading && (
<div className="animate-pulse bg-slate-200 rounded-md h-8 w-48" />
)}
{!isLoadTestsRoute && !isLoading && !!allBenchmarkRuns?.runs.length && (
<div>
<Select
Expand Down
12 changes: 10 additions & 2 deletions report/src/pages/RunComparison.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,16 @@ function RunComparison() {
});
}, [dataPerFile, selection.data]);

if (!benchmarkRuns || isLoadingBenchmarkRuns) {
return <div>Loading...</div>;
if (isLoadingBenchmarkRuns) {
return (
<div className="flex flex-col w-full min-h-screen">
<Navbar urlPrefix="/run-comparison" />
<div className="flex flex-col w-full flex-grow p-8 gap-4">
<div className="animate-pulse bg-slate-200 rounded h-6 w-48" />
<div className="animate-pulse bg-slate-100 rounded h-64 w-full" />
</div>
</div>
);
}

return (
Expand Down
12 changes: 10 additions & 2 deletions report/src/pages/RunIndex.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,16 @@ const RunIndex = () => {
};
}, [allBenchmarkRuns, benchmarkRunId]);

if (!benchmarkRuns || isLoadingBenchmarkRuns) {
return <div>Loading...</div>;
if (isLoadingBenchmarkRuns) {
return (
<div className="flex flex-col w-full min-h-screen">
<Navbar />
<div className="flex flex-col w-full flex-grow p-8 gap-4">
<div className="animate-pulse bg-slate-200 rounded h-6 w-48" />
<div className="animate-pulse bg-slate-100 rounded h-64 w-full" />
</div>
</div>
);
}

return <RunIndexInner benchmarkRuns={benchmarkRuns} />;
Expand Down
Loading