feat: show navbar immediately while metadata.json loads#196
Open
meyer9 wants to merge 1 commit into
Open
Conversation
- Add animated skeleton placeholder in the Navbar dropdown slot while useTestMetadata() is fetching, so layout doesn't shift on load - RunIndex: render Navbar + content skeleton during isLoadingBenchmarkRuns instead of a bare <div>Loading...</div> that hid the navbar entirely - RunComparison: same fix
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.jsoncan be slow to load. Previously the entire page render (including the navbar) was blocked behind the metadata fetch, showing just a bareLoading...div.Changes
Navbar.tsx: WhileuseTestMetadata()is in-flight on benchmark routes, render an animated skeleton placeholder in the dropdown slot so the navbar is immediately visible and the layout doesn't shift when the select appears.RunIndex.tsx/RunComparison.tsx: Replace the early-return<div>Loading...</div>with a full layout that renders<Navbar />plus skeleton content placeholders. The navbar now shows instantly while metadata loads.