Skip to content

Replace bare except with except Exception in execution.py #5663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace bare except with except Exception in execution.py #5663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sagemaker-train/src/sagemaker/train/evaluate/execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ def wait(
if ipython is not None and 'IPKernelApp' in ipython.config:
is_jupyter = True
from IPython.display import display, HTML, clear_output
except:
except Exception:
pass

if is_jupyter:
Expand Down Expand Up @@ -958,7 +958,7 @@ def wait(
end = datetime.fromisoformat(step.end_time.replace('Z', '+00:00'))
duration_seconds = (end - start).total_seconds()
duration = f"{duration_seconds:.1f}s"
except:
except Exception:
duration = "N/A"
elif step.start_time:
duration = "Running..."
Expand All @@ -982,7 +982,7 @@ def wait(
# Add error indicator if failures exist
if has_failures:
if step.failure_reason:
row_data.append("❌")
row_data.append("❌")
failed_steps.append(step)
else:
row_data.append("")
Expand All @@ -1005,7 +1005,7 @@ def wait(

for step in failed_steps:
content_parts.append(Text("")) # Empty line before each failure
content_parts.append(Text(f"• {step.display_name or step.name}:", style="bold red"))
content_parts.append(Text(f"• {step.display_name or step.name}:", style="bold red"))
content_parts.append(Text(f" {step.failure_reason}", style="red"))

combined_content = Group(*content_parts)
Expand Down
Loading