Replace bare except with except Exception in execution.py#5663
Open
harshadkhetpal wants to merge 1 commit intoaws:masterfrom
Open
Replace bare except with except Exception in execution.py#5663harshadkhetpal wants to merge 1 commit intoaws:masterfrom
harshadkhetpal wants to merge 1 commit intoaws:masterfrom
Conversation
harshadkhetpal
requested a deployment
to
manual-approval
GitHub Actions
Waiting
harshadkhetpal
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces bare
except:clauses withexcept Exception:insagemaker-train/src/sagemaker/train/evaluate/execution.py.Bare
except:catches all exceptions includingSystemExit,KeyboardInterrupt, andGeneratorExit, which are typically not intended to be caught. Usingexcept Exception:is the recommended practice as it only catches regular exceptions while allowing system-level exceptions to propagate normally.Changes
except:→except Exception:(IPython import fallback)except:→except Exception:(datetime parsing fallback)Testing
This is a safe behavioral improvement —
except Exception:covers all the same cases these handlers intend to catch (ImportError, ValueError, etc.) without accidentally suppressing KeyboardInterrupt or SystemExit.