Skip to content

Implement signature validation #6800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagnir merged 3 commits into from
Mar 18, 2026

Merge remote-tracking branch 'origin/feature/master/sns-message-manag…

8074fea
Select commit
Loading
Failed to load commit list.
Merged

Implement signature validation #6800

Merge remote-tracking branch 'origin/feature/master/sns-message-manag…
8074fea
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 18, 2026 in 15m 54s

Quality Gate failed

Failed conditions
1 Security Hotspot
37.9% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 73 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3RKKSwp4fGsyeZz&open=AZ0CJ3RKKSwp4fGsyeZz&pullRequest=6800

Check warning on line 21 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/model/SnsSubscriptionConfirmationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3rPKSwp4fGsyeaf&open=AZ0CJ3rPKSwp4fGsyeaf&pullRequest=6800

Check failure on line 52 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Message" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaQ&open=AZ0CJ3VQKSwp4fGsyeaQ&pullRequest=6800

Check warning on line 165 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3sjKSwp4fGsyeau&open=AZ0CJ3sjKSwp4fGsyeau&pullRequest=6800

Check warning on line 164 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SnsMessageUnmarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3sJKSwp4fGsyeaj&open=AZ0CJ3sJKSwp4fGsyeaj&pullRequest=6800

Check failure on line 48 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "SignatureVersion" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaX&open=AZ0CJ3VQKSwp4fGsyeaX&pullRequest=6800

Check warning on line 21 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/model/SnsUnsubscribeConfirmationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3qyKSwp4fGsyeae&open=AZ0CJ3qyKSwp4fGsyeae&pullRequest=6800

Check failure on line 48 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "MessageId" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaZ&open=AZ0CJ3VQKSwp4fGsyeaZ&pullRequest=6800

Check warning on line 652 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use isZero() instead. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3SYKSwp4fGsyeZ4&open=AZ0CJ3SYKSwp4fGsyeZ4&pullRequest=6800

Check warning on line 112 in services/sns/src/main/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Consider using the Consumer Builder method instead of creating this nested builder. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3WTKSwp4fGsyead&open=AZ0CJ3WTKSwp4fGsyead&pullRequest=6800

Check warning on line 231 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call "Optional#isPresent()" before accessing the value. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaO&open=AZ0CJ3VQKSwp4fGsyeaO&pullRequest=6800

Check warning on line 375 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3TeKSwp4fGsyeaE&open=AZ0CJ3TeKSwp4fGsyeaE&pullRequest=6800

Check warning on line 369 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetriever.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3UsKSwp4fGsyeaM&open=AZ0CJ3UsKSwp4fGsyeaM&pullRequest=6800

Check failure on line 55 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Token" 4 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaS&open=AZ0CJ3VQKSwp4fGsyeaS&pullRequest=6800

Check warning on line 189 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SnsMessageUnmarshallerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3sJKSwp4fGsyeal&open=AZ0CJ3sJKSwp4fGsyeal&pullRequest=6800

Check warning on line 109 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3sjKSwp4fGsyeaq&open=AZ0CJ3sjKSwp4fGsyeaq&pullRequest=6800

Check failure on line 60 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SnsMessageParser.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "MessageAttributes" 3 times. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3VQKSwp4fGsyeaW&open=AZ0CJ3VQKSwp4fGsyeaW&pullRequest=6800

Check warning on line 133 in services-custom/sns-message-manager/src/main/java/software/amazon/awssdk/messagemanager/sns/model/SnsMessage.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this generic name to match the regular expression '^[A-Z][0-9]?$'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3uPKSwp4fGsyeaz&open=AZ0CJ3uPKSwp4fGsyeaz&pullRequest=6800

Check warning on line 184 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/SignatureValidator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "getIssuerDN"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3T7KSwp4fGsyeaJ&open=AZ0CJ3T7KSwp4fGsyeaJ&pullRequest=6800

Check warning on line 235 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3TeKSwp4fGsyeaD&open=AZ0CJ3TeKSwp4fGsyeaD&pullRequest=6800

Check warning on line 390 in services/sns/src/test/java/software/amazon/awssdk/services/sns/messagemanager/SnsMessageManagerIntegrationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Join these multiple assertions subject to one assertion chain. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3TeKSwp4fGsyeaG&open=AZ0CJ3TeKSwp4fGsyeaG&pullRequest=6800

Check warning on line 261 in services/sns/src/main/java/software/amazon/awssdk/services/sns/internal/messagemanager/DefaultSnsMessageManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "createHttpDefaults" method. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3UTKSwp4fGsyeaL&open=AZ0CJ3UTKSwp4fGsyeaL&pullRequest=6800

Check warning on line 73 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/internal/SignatureValidatorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3sjKSwp4fGsyeao&open=AZ0CJ3sjKSwp4fGsyeao&pullRequest=6800

Check warning on line 21 in services-custom/sns-message-manager/src/test/java/software/amazon/awssdk/messagemanager/sns/model/SnsNotificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3rpKSwp4fGsyeag&open=AZ0CJ3rpKSwp4fGsyeag&pullRequest=6800

Check warning on line 33 in services/sns/src/test/java/software/amazon/awssdk/services/sns/internal/messagemanager/CertificateRetrieverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.concurrent.CompletableFuture'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZ0CJ3SYKSwp4fGsyeZ8&open=AZ0CJ3SYKSwp4fGsyeZ8&pullRequest=6800
View more details on SonarQubeCloud