Skip to content

Implement signature validation#6800

Merged
dagnir merged 3 commits intofeature/master/sns-message-managerfrom
dongie/sns-sig-verification
Mar 18, 2026
Merged

Implement signature validation#6800
dagnir merged 3 commits intofeature/master/sns-message-managerfrom
dongie/sns-sig-verification

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Mar 16, 2026

Motivation and Context

Implement signature validation for SNS message.

Modifications

Testing

  • New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner March 16, 2026 21:24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this and the other test messages are real notifications sent from SNS. Ditto for SimpleNotificationService-7506a1e35b36ef5a444dd1a8e7cc3ed8.pem file.

@dagnir dagnir force-pushed the dongie/sns-sig-verification branch 2 times, most recently from 0a9ce74 to 9655d04 Compare March 17, 2026 17:10
@dagnir dagnir force-pushed the dongie/sns-sig-verification branch from fa810a8 to cfd4965 Compare March 17, 2026 21:36
@sonarqubecloud
Copy link

@dagnir dagnir merged commit fba4644 into feature/master/sns-message-manager Mar 18, 2026
18 of 20 checks passed
@dagnir dagnir deleted the dongie/sns-sig-verification branch March 18, 2026 17:18
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants