Skip to content

fix(lambda-http): into_api_gateway_v2_request joins cookies with "; " #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbougerel wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(lambda-http): into_api_gateway_v2_request joins cookies with "; " #1143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lambda-http/src/request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ fn into_api_gateway_v2_request(ag: ApiGatewayV2httpRequest) -> http::Request<Bod

let mut headers = ag.headers;
if let Some(cookies) = ag.cookies {
if let Ok(header_value) = HeaderValue::from_str(&cookies.join(";")) {
if let Ok(header_value) = HeaderValue::from_str(&cookies.join("; ")) {
headers.insert(http::header::COOKIE, header_value);
}
}
Expand Down Expand Up @@ -570,7 +570,7 @@ mod tests {

assert_eq!(req.method(), "POST");
assert_eq!(req.uri(), "https://id.execute-api.us-east-1.amazonaws.com/my/path?parameter1=value1&parameter1=value2&parameter2=value");
assert_eq!(cookie_header, Ok("cookie1=value1;cookie2=value2"));
assert_eq!(cookie_header, Ok("cookie1=value1; cookie2=value2"));

// Ensure this is an APIGWv2 request
let req_context = req.request_context_ref().expect("Request is missing RequestContext");
Expand Down
Loading