fix(lambda-http): into_api_gateway_v2_request joins cookies with "; "#1143
Open
fix(lambda-http): into_api_gateway_v2_request joins cookies with "; "#1143
Conversation
into_api_gateway_v2_request reconstructs the Cookie header by joining the cookies array from the API Gateway v2 event payload with ";" (no space). This violates RFC 6265 §4.2.1, which mandates "; " (semicolon followed by a space) as the cookie-pair separator. The result is a non-compliant Cookie header that breaks any downstream cookie parser that follows the spec strictly like BetterAuth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
into_api_gateway_v2_requestreconstructs the Cookie header by joining the cookies array from the API Gateway v2 event payload with";"(no space). This violates RFC 6265 §4.2.1, which mandates"; "(semicolon followed by a space) as the cookie-pair separator. The result is a non-compliant Cookie header that breaks any downstream cookie parser that follows the spec strictly like BetterAuth.📬 Issue #, if available:
Closes #1142
✍️ Description of changes:
The
Cookieheader reconstructed frominto_api_gateway_v2_requestnow joins pairs with"; "to produce a spec-compliant value:The corresponding test was updated.
🔏 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.