Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Conversation

@rustielin
Copy link
Contributor

@rustielin rustielin commented Jun 18, 2025

Canary for #991

It works because in this stack, this PR is targeting the branch 06-18-_gha_allow_external_contributors_build_lint, so under pull_request_target, it will use the ci.yml workflow file from that branch.

Test plan

CI works, and Semgrep passes

@vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 6:31pm

Copy link
Contributor Author

rustielin commented Jun 18, 2025

@rustielin rustielin marked this pull request as ready for review June 18, 2025 22:44
@rustielin rustielin requested a review from zi0Black June 18, 2025 22:53
@rustielin rustielin force-pushed the 06-18-_gha_allow_external_contributors_build_lint branch 2 times, most recently from c451f29 to 7675e73 Compare June 18, 2025 23:02
@rustielin rustielin force-pushed the 06-18-_gha_canary_allow_external_contributors_build_lint branch from 1907e47 to 498d84a Compare June 18, 2025 23:02
@rustielin rustielin changed the title [gha][canary] allow external contributors build/lint [gha/test]Add canary branch for external contributors build lint Jul 3, 2025
@rustielin rustielin changed the title [gha/test]Add canary branch for external contributors build lint [gha/test] Add canary branch for external contributors build lint Jul 3, 2025
Copy link
Contributor Author

rustielin commented Jul 3, 2025

Merge activity

  • Jul 3, 5:53 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 3, 6:17 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 3, 6:32 PM UTC: @rustielin merged this pull request with Graphite.

@rustielin rustielin changed the base branch from 06-18-_gha_allow_external_contributors_build_lint to graphite-base/992 July 3, 2025 17:54
rustielin added a commit that referenced this pull request Jul 3, 2025
This PR introduces `pull_request_target` for the main CI build/lint job. It requires  permissions since there are some internal packages that are used in part of the build. The `permission-check` job ensures the permissions are locked down, and Semgrep enforces that job's existence. 

This PR is tested by #992 , which should be safe to land alongside it as long as Semgrep passes on it
@rustielin rustielin changed the base branch from graphite-base/992 to main July 3, 2025 18:16
@rustielin rustielin force-pushed the 06-18-_gha_canary_allow_external_contributors_build_lint branch from 498d84a to 31984cc Compare July 3, 2025 18:17
@rustielin rustielin merged commit 252bd9b into main Jul 3, 2025
3 of 4 checks passed
@rustielin rustielin deleted the 06-18-_gha_canary_allow_external_contributors_build_lint branch July 3, 2025 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants