This repository was archived by the owner on Jul 30, 2025. It is now read-only.
[gha] allow external contributors build/lint #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rustielin
force-pushed
the
06-18-_gha_fix_artifactregistry_login
branch
from
da3188a to
24f4686
Compare
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
0ff38ff to
ac4c657
Compare
rustielin
force-pushed
the
06-18-_gha_fix_artifactregistry_login
branch
from
24f4686 to
9a846bc
Compare
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
ac4c657 to
9b8cb25
Compare
rustielin
force-pushed
the
06-18-_gha_fix_artifactregistry_login
branch
from
9a846bc to
d274994
Compare
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
9b8cb25 to
4b91cbc
Compare
rustielin
force-pushed
the
06-18-_gha_fix_artifactregistry_login
branch
from
d274994 to
fc5ee95
Compare
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
4b91cbc to
8961daf
Compare
gregnazario
approved these changes
Jun 18, 2025
rustielin
changed the base branch from
06-18-_gha_fix_artifactregistry_login
to
graphite-base/991
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
8961daf to
c451f29
Compare
rustielin
force-pushed
the
graphite-base/991
branch
from
fc5ee95 to
067b1ec
Compare
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
c451f29 to
7675e73
Compare
sionescu
approved these changes
Jun 18, 2025
Contributor
Author
Merge activity
|
rustielin
force-pushed
the
06-18-_gha_allow_external_contributors_build_lint
branch
from
7675e73 to
90fc823
Compare
rustielin
added a commit
that referenced
this pull request
Jul 3, 2025
Canary for #991 It works because in this stack, this PR is targeting the branch `06-18-_gha_allow_external_contributors_build_lint`, so under `pull_request_target`, it will use the `ci.yml` workflow file from that branch. ## Test plan CI works, and Semgrep passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
pull_request_targetfor the main CI build/lint job. It requires permissions since there are some internal packages that are used in part of the build. Thepermission-checkjob ensures the permissions are locked down, and Semgrep enforces that job's existence.This PR is tested by #992 , which should be safe to land alongside it as long as Semgrep passes on it