Skip to content

Release Apollo Java 2.5.0 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nobodyiam wants to merge 1 commit into from
Closed

Release Apollo Java 2.5.0 #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</developers>

<properties>
<revision>2.5.0-SNAPSHOT</revision>
<revision>2.5.0</revision>
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

CHANGES.md was not updated for this release.

The PR checklist explicitly marks "Update CHANGES log: not completed." Per project convention, each release entry in CHANGES.md must be a Markdown link whose text is the change description and whose target is the PR URL (e.g., [Release Apollo Java 2.5.0](https://github.com/apolloconfig/apollo-java/pull/129)). Please add the entry before merging.

Based on learnings: "Format CHANGES.md entries as Markdown links with link text as change description and link target as PR URL (not issue URL)."

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pom.xml` at line 63, Update CHANGES.md to add a release entry for version
2.5.0 following project convention: add a Markdown link whose text is the change
description (e.g., "Release Apollo Java 2.5.0") and whose target is the PR URL
for this change (not the issue URL); ensure the entry corresponds to the
<revision>2.5.0</revision> in pom.xml and matches the exact PR number/URL for
this merge.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for residual SNAPSHOT references in pom files and other resource files
echo "=== Checking for SNAPSHOT references in XML files ==="
rg -n "SNAPSHOT" --type xml 2>/dev/null | head -20

echo ""
echo "=== Checking for 2.5.0-SNAPSHOT specifically ==="
rg -n "2\.5\.0-SNAPSHOT" 2>/dev/null

echo ""
echo "=== Checking root pom.xml structure around line 63 ==="
sed -n '55,75p' pom.xml

echo ""
echo "=== Checking flatten-maven-plugin configuration ==="
sed -n '326,348p' pom.xml

echo ""
echo "=== Checking for CHANGES.md and its status ==="
if [ -f CHANGES.md ]; then
  echo "CHANGES.md exists. Last 10 lines:"
  tail -10 CHANGES.md
else
  echo "CHANGES.md not found"
  find . -name "CHANGES*" -o -name "CHANGELOG*" 2>/dev/null | head -10
fi

Repository: apolloconfig/apollo-java

Length of output: 2999

LGTM — correct use of CI-friendly versioning.

The single-property bump correctly propagates to all submodules via flatten-maven-plugin (resolveCiFriendliesOnly mode), so no child POM edits are needed. No residual -SNAPSHOT version strings were found in the codebase.

Update CHANGES.md for version 2.5.0 before release. The project convention requires entries in Markdown link format with PR URLs (e.g., [Description](https://github.com/apolloconfig/apollo-java/pull/XXX)). This was noted as incomplete in the PR checklist and must be completed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@pom.xml` at line 63, Update CHANGES.md to add the release notes for version
2.5.0: create Markdown entries for each change following the project convention
"[Description](https://github.com/apolloconfig/apollo-java/pull/XXX)" so every
entry includes a short description and the PR URL, ensure the new entries are
grouped under the 2.5.0 heading to match the bumped <revision>2.5.0</revision>
and satisfy the PR checklist.

<java.version>1.8</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<spring-boot.version>2.7.18</spring-boot.version>
Expand Down