Conversation
📝 WalkthroughWalkthroughUpdated Maven project version from 2.5.0-SNAPSHOT to 2.5.0 in pom.xml by modifying the revision property, converting the development snapshot version to a release version. Changes
Possibly related PRs
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
============================================
+ Coverage 68.68% 70.96% +2.28%
- Complexity 1503 1632 +129
============================================
Files 212 224 +12
Lines 6396 6727 +331
Branches 647 679 +32
============================================
+ Hits 4393 4774 +381
+ Misses 1673 1601 -72
- Partials 330 352 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pom.xml`:
- Line 63: Update CHANGES.md to add a release entry for version 2.5.0 following
project convention: add a Markdown link whose text is the change description
(e.g., "Release Apollo Java 2.5.0") and whose target is the PR URL for this
change (not the issue URL); ensure the entry corresponds to the
<revision>2.5.0</revision> in pom.xml and matches the exact PR number/URL for
this merge.
- Line 63: Update CHANGES.md to add the release notes for version 2.5.0: create
Markdown entries for each change following the project convention
"[Description](https://github.com/apolloconfig/apollo-java/pull/XXX)" so every
entry includes a short description and the PR URL, ensure the new entries are
grouped under the 2.5.0 heading to match the bumped <revision>2.5.0</revision>
and satisfy the PR checklist.
|
|
||
| <properties> | ||
| <revision>2.5.0-SNAPSHOT</revision> | ||
| <revision>2.5.0</revision> |
There was a problem hiding this comment.
CHANGES.md was not updated for this release.
The PR checklist explicitly marks "Update CHANGES log: not completed." Per project convention, each release entry in CHANGES.md must be a Markdown link whose text is the change description and whose target is the PR URL (e.g., [Release Apollo Java 2.5.0](https://github.com/apolloconfig/apollo-java/pull/129)). Please add the entry before merging.
Based on learnings: "Format CHANGES.md entries as Markdown links with link text as change description and link target as PR URL (not issue URL)."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pom.xml` at line 63, Update CHANGES.md to add a release entry for version
2.5.0 following project convention: add a Markdown link whose text is the change
description (e.g., "Release Apollo Java 2.5.0") and whose target is the PR URL
for this change (not the issue URL); ensure the entry corresponds to the
<revision>2.5.0</revision> in pom.xml and matches the exact PR number/URL for
this merge.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for residual SNAPSHOT references in pom files and other resource files
echo "=== Checking for SNAPSHOT references in XML files ==="
rg -n "SNAPSHOT" --type xml 2>/dev/null | head -20
echo ""
echo "=== Checking for 2.5.0-SNAPSHOT specifically ==="
rg -n "2\.5\.0-SNAPSHOT" 2>/dev/null
echo ""
echo "=== Checking root pom.xml structure around line 63 ==="
sed -n '55,75p' pom.xml
echo ""
echo "=== Checking flatten-maven-plugin configuration ==="
sed -n '326,348p' pom.xml
echo ""
echo "=== Checking for CHANGES.md and its status ==="
if [ -f CHANGES.md ]; then
echo "CHANGES.md exists. Last 10 lines:"
tail -10 CHANGES.md
else
echo "CHANGES.md not found"
find . -name "CHANGES*" -o -name "CHANGELOG*" 2>/dev/null | head -10
fiRepository: apolloconfig/apollo-java
Length of output: 2999
LGTM — correct use of CI-friendly versioning.
The single-property bump correctly propagates to all submodules via flatten-maven-plugin (resolveCiFriendliesOnly mode), so no child POM edits are needed. No residual -SNAPSHOT version strings were found in the codebase.
Update CHANGES.md for version 2.5.0 before release. The project convention requires entries in Markdown link format with PR URLs (e.g., [Description](https://github.com/apolloconfig/apollo-java/pull/XXX)). This was noted as incomplete in the PR checklist and must be completed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pom.xml` at line 63, Update CHANGES.md to add the release notes for version
2.5.0: create Markdown entries for each change following the project convention
"[Description](https://github.com/apolloconfig/apollo-java/pull/XXX)" so every
entry includes a short description and the PR URL, ensure the new entries are
grouped under the 2.5.0 heading to match the bumped <revision>2.5.0</revision>
and satisfy the PR checklist.
1 participant
What's the purpose of this PR
Prepare Apollo Java 2.5.0 release by removing
-SNAPSHOTfrom root revision.Which issue(s) this PR fixes:
Fixes #N/A (release task)
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit