Skip to content

netutils/dhcpc: avoid setting IP to stack when oldaddr matches presult->ipaddr #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangchen61698 wants to merge 1 commit into
base: master
from
+8 −3
Open

netutils/dhcpc: avoid setting IP to stack when oldaddr matches presult->ipaddr #3264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions netutils/dhcpc/dhcpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,11 +817,16 @@ int dhcpc_request(FAR void *handle, FAR struct dhcpc_state *presult)
pdhcpc->serverid.s_addr = presult->serverid.s_addr;

/* Temporarily use the address offered by the server
* and break out of the loop.
* if it differs from the current address, then break
* out of the loop.
*/

netlib_set_ipv4addr(pdhcpc->interface,
&presult->ipaddr);
if (oldaddr.s_addr != presult->ipaddr.s_addr)
{
netlib_set_ipv4addr(pdhcpc->interface,
&presult->ipaddr);
}

state = STATE_HAVE_OFFER;
}
}
Expand Down