netutils/dhcpc: avoid setting IP to stack when oldaddr matches presult->ipaddr #3264
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerpelea
changed the title
jerpelea
previously approved these changes
Dec 22, 2025
simbit18
requested review from
acassis,
cederom,
linguini1 and
xiaoxiang781216
acassis
reviewed
Dec 22, 2025
xiaoxiang781216
previously approved these changes
Dec 22, 2025
linguini1
requested changes
Dec 22, 2025
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
What is the self-test? What were the results (and are there any test logs)? Can you say anything about the arch/chip of the test machine? Please provide some more testing information.
when processing DHCP offer messages in dhcp_dequest, netlib_set_ipv4addr is used to set the IP regardless of whether the IP has changed, resulting in disconnection between the two communication devices Signed-off-by: wangchen <wangchen41@xiaomi.com>
wangchen61698
dismissed stale reviews from xiaoxiang781216 and jerpelea
via
51b0814
xiaoxiang781216
approved these changes
Dec 23, 2025
acassis
approved these changes
Dec 23, 2025
Contributor
|
@linguini1 please review |
Contributor
I would still like to know what the testing is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
when processing DHCP offer messages in dhcp_dequest, netlib_set_ipv4addr is used to set the IP regardless of whether the IP has changed, resulting in disconnection between the two communication devices
Impact
dhcpc setting ip addr
Testing
It has passed self-testing in true machine(speaker equipment)