Skip to content

Subscription: address topic owner review comments

82049d7
Select commit
Loading
Failed to load commit list.
Open

Subscription: add topic owner epoch fencing #17780

Subscription: address topic owner review comments
82049d7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 8, 2026 in 3m 5s

Annotations

Check warning on line 230 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionTopicAgent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5tL9KoIXSMjp_lilog&open=AZ5tL9KoIXSMjp_lilog&pullRequest=17780

Check warning on line 24 in iotdb-client/subscription/src/main/java/org/apache/iotdb/rpc/subscription/exception/SubscriptionOwnerFencedException.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This class has 8 parents which is greater than 5 authorized.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPRoYgb0IV-Vu4_D&open=AZ5uLPRoYgb0IV-Vu4_D&pullRequest=17780

Check warning on line 472 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'{' at column 9 should be on the previous line.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4--&open=AZ5uLPLMYgb0IV-Vu4--&pullRequest=17780

Check warning on line 2684 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 111 to 64, Complexity from 22 to 14, Nesting Level from 6 to 2, Number of Variables from 22 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6RFuMz5nSEz7HZmadX&open=AZ6RFuMz5nSEz7HZmadX&pullRequest=17780

Check warning on line 2342 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 178 to 64, Complexity from 21 to 14, Nesting Level from 4 to 2, Number of Variables from 22 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6RFuFb5nSEz7HZmadO&open=AZ6RFuFb5nSEz7HZmadO&pullRequest=17780

Check warning on line 3085 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 82 to 64, Complexity from 16 to 14, Nesting Level from 3 to 2, Number of Variables from 25 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6l7p4vEJXKApSizP6w&open=AZ6l7p4vEJXKApSizP6w&pullRequest=17780

Check warning on line 3735 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 81 to 64, Complexity from 15 to 14, Nesting Level from 3 to 2, Number of Variables from 18 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6l7p4vEJXKApSizP6x&open=AZ6l7p4vEJXKApSizP6x&pullRequest=17780

Check warning on line 221 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionTopicAgent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 108).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5tL9KoIXSMjp_lilof&open=AZ5tL9KoIXSMjp_lilof&pullRequest=17780

Check warning on line 476 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4_B&open=AZ5uLPLMYgb0IV-Vu4_B&pullRequest=17780

Check warning on line 473 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4-_&open=AZ5uLPLMYgb0IV-Vu4-_&pullRequest=17780

Check warning on line 5028 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 80 to 64, Complexity from 15 to 14, Nesting Level from 3 to 2, Number of Variables from 25 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6l7p4vEJXKApSizP6y&open=AZ6l7p4vEJXKApSizP6y&pullRequest=17780

Check warning on line 2096 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 89 to 64, Complexity from 27 to 14, Nesting Level from 4 to 2, Number of Variables from 9 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6RFuJK5nSEz7HZmadV&open=AZ6RFuJK5nSEz7HZmadV&pullRequest=17780

Check warning on line 2011 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 81 to 64, Complexity from 29 to 14, Nesting Level from 4 to 2, Number of Variables from 10 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6l7pybEJXKApSizP6v&open=AZ6l7pybEJXKApSizP6v&pullRequest=17780

Check warning on line 475 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block' child has incorrect indentation level 10, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4_A&open=AZ5uLPLMYgb0IV-Vu4_A&pullRequest=17780

Check warning on line 477 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block rcurly' has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4_C&open=AZ5uLPLMYgb0IV-Vu4_C&pullRequest=17780

Check warning on line 3376 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/analyzer/StatementAnalyzer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 121 to 64, Complexity from 18 to 14, Nesting Level from 3 to 2, Number of Variables from 35 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6RFuMz5nSEz7HZmadY&open=AZ6RFuMz5nSEz7HZmadY&pullRequest=17780

Check warning on line 212 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/agent/SubscriptionTopicAgent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 105).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5tL9KoIXSMjp_liloe&open=AZ5tL9KoIXSMjp_liloe&pullRequest=17780

Check warning on line 472 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'block lcurly' has incorrect indentation level 8, expected level should be 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ5uLPLMYgb0IV-Vu4-9&open=AZ5uLPLMYgb0IV-Vu4-9&pullRequest=17780

Check failure on line 532 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/DataNodeSqlFormatter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "WITH (" 3 times.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6RFuJz5nSEz7HZmadW&open=AZ6RFuJz5nSEz7HZmadW&pullRequest=17780

Check warning on line 4761 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/parser/ASTVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 97 to 64, Complexity from 20 to 14, Nesting Level from 3 to 2, Number of Variables from 14 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ6l7p7bEJXKApSizP6z&open=AZ6l7p7bEJXKApSizP6z&pullRequest=17780