Subscription: add topic owner epoch fencing#17780
Open
VGalaxies wants to merge 3 commits into
Open
Conversation
Collaborator
|
Findings
( 和 TopicMetaKeeper.java#L112 (https://github.com/apache/iotdb/blob/76f2a882411ba790f7db290740f0232a1e5c4022/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/subscription/meta/topic/TopicMetaKeeper.java#L112)。建议改成版本化或长度前缀格式，或只从
( 和 SubscriptionInfo.java#L340 (https://github.com/apache/iotdb/blob/76f2a882411ba790f7db290740f0232a1e5c4022/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/subscription/SubscriptionInfo.java#L340)。建议在
(https://github.com/apache/iotdb/blob/76f2a882411ba790f7db290740f0232a1e5c4022/iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionProvider.java#L445)。建议显式处理 |
VGalaxies
force-pushed
the
subscription-topic-owner-fencing
branch
from
76f2a88 to
b6086b2
Compare
Contributor
Author
|
Thanks @Caideyipi, addressed the three findings in b6086b2.
Local verification passed:
The Sonar duplication check is queued again on the new commit; I will follow up if the rerun still fails. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17780 +/- ##
============================================
+ Coverage 40.58% 40.84% +0.25%
- Complexity 2575 2616 +41
============================================
Files 5181 5204 +23
Lines 350404 354127 +3723
Branches 44801 45303 +502
============================================
+ Hits 142225 144635 +2410
- Misses 208179 209492 +1313 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
Jun 2, 2026
Contributor
jt2594838
left a comment
jt2594838
left a comment
There was a problem hiding this comment.
Add an IT to show a complete use case.
VGalaxies
force-pushed
the
subscription-topic-owner-fencing
branch
from
b6086b2 to
25c34c2
Compare
Contributor
Author
|
Addressed the latest review comments in 25c34c2.
Local verification:
|
jt2594838
reviewed
Jun 3, 2026
|
jt2594838
reviewed
Jun 8, 2026
Contributor
jt2594838
left a comment
jt2594838
left a comment
There was a problem hiding this comment.
Have you waited for all leases to expire before transferring the ownership?
Comment on lines
+102
to
+112
| /** | ||
| * Alters a topic with the specified properties. | ||
| * | ||
| * @param topicName If the topic name contains single quotes, the passed parameter needs to be | ||
| * enclosed in backticks. | ||
| * @param properties A {@link Properties} object containing the topic properties to alter. | ||
| * @throws IoTDBConnectionException If a connection issue occurs. | ||
| * @throws StatementExecutionException If the SQL statement execution fails. | ||
| */ | ||
| void alterTopic(final String topicName, final Properties properties) | ||
| throws IoTDBConnectionException, StatementExecutionException; |
Contributor
There was a problem hiding this comment.
Is the TopicOwner allowed to be modified by this interface?
Or can it only be modified through alterTopicOwner?
Comment on lines
+166
to
+171
| public TopicMeta buildAlteredTopicMeta(TAlterTopicReq req) { | ||
| final TopicMeta existedTopicMeta = subscriptionInfo.deepCopyTopicMeta(req.getTopicName()); | ||
| return existedTopicMeta == null | ||
| ? null | ||
| : existedTopicMeta.deepCopyWithUpdatedAttributes(req.getTopicAttributes()); | ||
| } |
Comment on lines
+1747
to
+1751
| return new TSStatus(TSStatusCode.ALTER_TOPIC_ERROR.getStatusCode()) | ||
| .setMessage( | ||
| String.format( | ||
| "Failed to alter topic %s, the topic is not existed", req.getTopicName())); | ||
| } |
Comment on lines
+4435
to
+4438
| } else { | ||
| throw new SemanticException( | ||
| "Not support for this sql in ALTER TOPIC, please enter topicName."); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests