Skip to content

Drop RxJava 2 #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschmitt merged 1 commit into from
Jul 29, 2025
Merged

Drop RxJava 2 #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions httpcore5-testing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava2</groupId>
<artifactId>rxjava</artifactId>
<version>${rxjava.version}</version>
</dependency>
<dependency>
<groupId>io.reactivex.rxjava3</groupId>
<artifactId>rxjava</artifactId>
Expand Down Expand Up @@ -161,4 +156,4 @@
</plugins>
</reporting>

</project>
</project>
158 changes: 0 additions & 158 deletions httpcore5-testing/src/main/java/org/apache/hc/core5/testing/reactive/ReactiveTestUtils.java
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
<mockito.version>4.11.0</mockito.version>
<slf4j.version>1.7.36</slf4j.version>
<log4j.version>2.25.0</log4j.version>
<rxjava.version>2.2.21</rxjava.version>
<rxjava3.version>3.1.10</rxjava3.version>
<testcontainers.version>1.21.3</testcontainers.version>
<api.comparison.version>5.3</api.comparison.version>
Expand Down Expand Up @@ -232,6 +231,7 @@
<parameter>
<breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications>
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
<ignoreMissingClasses>true</ignoreMissingClasses>
Copy link
Member

@ok2c ok2c Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschmitt This is due to formatting, is it not?

Copy link
Contributor Author

@rschmitt rschmitt Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I changed this by hand. This option appeared to be in the wrong section and wasn't taking effect. Without this option here, japicmp fails because the current version's classpath is missing the RxJava 2 classes (not to be confused with the missing ReactiveTestUtils class). Evidently, ignoreMissingClasses needs to be set in the build plugin config, not the reporting plugin config.

<overrideCompatibilityChangeParameters>
<overrideCompatibilityChangeParameter>
<compatibilityChange>METHOD_NEW_DEFAULT</compatibilityChange>
Expand All @@ -241,6 +241,7 @@
</overrideCompatibilityChangeParameters>
<excludes>
<exclude>@org.apache.hc.core5.annotation.Internal</exclude>
<exclude>org.apache.hc.core5.testing.reactive.ReactiveTestUtils</exclude>
</excludes>
</parameter>
</configuration>
Expand Down Expand Up @@ -369,7 +370,6 @@
<excludes>
<exclude>@org.apache.hc.core5.annotation.Internal</exclude>
</excludes>
<ignoreMissingClasses>true</ignoreMissingClasses>
</parameter>
</configuration>
</plugin>
Expand All @@ -382,4 +382,4 @@
</plugins>
</reporting>

</project>
</project>
Loading