Drop RxJava 2 #540
Merged
Drop RxJava 2 #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RxJava 2 is end-of-life as of February 28, 2021. `ReactiveTestUtils` can probably be dropped for 5.6 in favor of `Reactive3TestUtils`.
ok2c
approved these changes
Jul 29, 2025
| <parameter> | ||
| <breakBuildOnBinaryIncompatibleModifications>true</breakBuildOnBinaryIncompatibleModifications> | ||
| <breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications> | ||
| <ignoreMissingClasses>true</ignoreMissingClasses> |
Contributor
Author
There was a problem hiding this comment.
No, I changed this by hand. This option appeared to be in the wrong section and wasn't taking effect. Without this option here, japicmp fails because the current version's classpath is missing the RxJava 2 classes (not to be confused with the missing ReactiveTestUtils class). Evidently, ignoreMissingClasses needs to be set in the build plugin config, not the reporting plugin config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RxJava 2 is end-of-life as of February 28, 2021.
ReactiveTestUtilscan probably be dropped for 5.6 in favor ofReactive3TestUtils.