-
Notifications
You must be signed in to change notification settings - Fork 983
Add Zstandardto async content compression #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arturobernalg
merged 1 commit into
apache:master
from
arturobernalg:aasync-transparent-content-decompression-zstd
Aug 18, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
352 changes: 352 additions & 0 deletions
352
...5/src/main/java/org/apache/hc/client5/http/async/methods/DeflatingZstdEntityProducer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,352 @@ | ||
| /* | ||
| * ==================================================================== | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * ==================================================================== | ||
| * | ||
| * This software consists of voluntary contributions made by many | ||
| * individuals on behalf of the Apache Software Foundation. For more | ||
| * information on the Apache Software Foundation, please see | ||
| * <http://www.apache.org/>. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.hc.client5.http.async.methods; | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.ByteBuffer; | ||
| import java.util.ArrayDeque; | ||
| import java.util.Collections; | ||
| import java.util.Deque; | ||
| import java.util.Set; | ||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| import com.github.luben.zstd.ZstdDirectBufferCompressingStream; | ||
|
|
||
| import org.apache.hc.core5.http.Header; | ||
| import org.apache.hc.core5.http.nio.AsyncEntityProducer; | ||
| import org.apache.hc.core5.http.nio.DataStreamChannel; | ||
| import org.apache.hc.core5.util.Args; | ||
|
|
||
| /** | ||
| * {@code AsyncEntityProducer} that compresses the bytes produced by a delegate entity | ||
| * into a single <a href="https://www.rfc-editor.org/rfc/rfc8878">Zstandard</a> (zstd) frame | ||
| * on the fly. | ||
| * | ||
| * <p>This producer wraps a {@link org.apache.hc.core5.http.nio.AsyncEntityProducer} and | ||
| * performs streaming, ByteBuffer-to-ByteBuffer compression as the delegate writes to the | ||
| * provided {@link org.apache.hc.core5.http.nio.DataStreamChannel}. No {@code InputStream} | ||
| * is used in the client pipeline.</p> | ||
| * | ||
| * <p>Metadata reported by this producer:</p> | ||
| * <ul> | ||
| * <li>{@link #getContentEncoding()} returns {@code "zstd"}.</li> | ||
| * <li>{@link #getContentLength()} returns {@code -1} (unknown after compression).</li> | ||
| * <li>{@link #isChunked()} returns {@code true} (requests are typically sent chunked).</li> | ||
| * </ul> | ||
| * | ||
| * <h3>Usage</h3> | ||
| * <pre>{@code | ||
| * AsyncEntityProducer plain = new StringAsyncEntityProducer("payload", ContentType.TEXT_PLAIN); | ||
| * AsyncEntityProducer zstd = new DeflatingZstdEntityProducer(plain); | ||
| * | ||
| * SimpleHttpRequest req = SimpleRequestBuilder.post("http://localhost/echo") | ||
| * .setHeader(HttpHeaders.CONTENT_ENCODING, "zstd") // inform the server | ||
| * .build(); | ||
| * | ||
| * client.execute( | ||
| * new BasicRequestProducer(req, zstd), | ||
| * new BasicResponseConsumer<>(new StringAsyncEntityConsumer()), | ||
| * null); | ||
| * }</pre> | ||
| * | ||
| * <h3>Behavior</h3> | ||
| * <ul> | ||
| * <li><b>Streaming & back-pressure:</b> compressed output is staged in direct | ||
| * {@link java.nio.ByteBuffer}s and written only when the channel accepts bytes. | ||
| * When {@code DataStreamChannel.write(...)} returns {@code 0}, the producer pauses and | ||
| * requests another output turn.</li> | ||
| * <li><b>Finalization:</b> after the delegate signals {@code endStream()}, this producer emits | ||
| * the zstd frame epilogue and then calls {@code DataStreamChannel.endStream()}.</li> | ||
| * <li><b>Repeatability:</b> repeatable only if the delegate is repeatable.</li> | ||
| * <li><b>Headers:</b> callers are responsible for sending {@code Content-Encoding: zstd} on | ||
| * the request if required by the server. Content length is not known in advance.</li> | ||
| * <li><b>Resources:</b> invoke {@link #releaseResources()} to free native compressor resources.</li> | ||
| * </ul> | ||
| * | ||
| * <h3>Constructors</h3> | ||
| * <ul> | ||
| * <li>{@code DeflatingZstdEntityProducer(delegate)} – uses a default compression level.</li> | ||
| * <li>{@code DeflatingZstdEntityProducer(delegate, level)} – explicitly sets the zstd level.</li> | ||
| * </ul> | ||
| * | ||
| * <h3>Thread-safety</h3> | ||
| * <p>Not thread-safe; one instance per message exchange.</p> | ||
| * | ||
| * <h3>Runtime dependency</h3> | ||
| * <p>Requires {@code com.github.luben:zstd-jni} on the classpath.</p> | ||
| * | ||
| * @see org.apache.hc.client5.http.async.methods.InflatingZstdDataConsumer | ||
| * @see org.apache.hc.core5.http.nio.support.BasicRequestProducer | ||
| * @see org.apache.hc.core5.http.nio.entity.StringAsyncEntityProducer | ||
| * @see org.apache.hc.client5.http.impl.async.ContentCompressionAsyncExec | ||
| * @since 5.6 | ||
| */ | ||
| public final class DeflatingZstdEntityProducer implements AsyncEntityProducer { | ||
|
|
||
| private static final int IN_BUF = 64 * 1024; | ||
| private static final int OUT_BUF_DEFAULT = 128 * 1024; | ||
|
|
||
| private final AsyncEntityProducer delegate; | ||
|
|
||
| /** | ||
| * Direct staging for heap inputs. | ||
| */ | ||
| private final ByteBuffer inDirect = ByteBuffer.allocateDirect(IN_BUF); | ||
|
|
||
| /** | ||
| * Pending compressed output buffers, ready to write (pos=0..limit). | ||
| */ | ||
| private final Deque<ByteBuffer> pending = new ArrayDeque<>(); | ||
|
|
||
| /** | ||
| * Current output buffer owned by zstd; replaced when it overflows or flushes. | ||
| */ | ||
| private ByteBuffer outBuf; | ||
|
|
||
| /** | ||
| * Zstd compressor stream. | ||
| */ | ||
| private ZstdDirectBufferCompressingStream zstream; | ||
|
|
||
| private volatile boolean upstreamEnded = false; | ||
| private volatile boolean finished = false; | ||
| private final AtomicBoolean released = new AtomicBoolean(false); | ||
|
|
||
| private final int level; | ||
| private final int outCap; | ||
|
|
||
| public DeflatingZstdEntityProducer(final AsyncEntityProducer delegate) { | ||
| this(delegate, 3); // default compression level | ||
| } | ||
|
|
||
| public DeflatingZstdEntityProducer(final AsyncEntityProducer delegate, final int level) { | ||
| this.delegate = Args.notNull(delegate, "delegate"); | ||
| this.level = level; | ||
| inDirect.limit(0); | ||
|
|
||
| // Pick a sensible out buffer size (at least the recommended size). | ||
| final int rec = ZstdDirectBufferCompressingStream.recommendedOutputBufferSize(); | ||
| this.outCap = Math.max(OUT_BUF_DEFAULT, rec); | ||
| outBuf = ByteBuffer.allocateDirect(outCap); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isRepeatable() { | ||
| return delegate.isRepeatable(); | ||
| } | ||
|
|
||
| @Override | ||
| public long getContentLength() { | ||
| return -1; | ||
| } // unknown after compression | ||
|
|
||
| @Override | ||
| public String getContentType() { | ||
| return delegate.getContentType(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getContentEncoding() { | ||
| return "zstd"; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isChunked() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public Set<String> getTrailerNames() { | ||
| return Collections.emptySet(); | ||
| } | ||
|
|
||
| @Override | ||
| public int available() { | ||
| if (!pending.isEmpty()) { | ||
| final ByteBuffer head = pending.peekFirst(); | ||
| return head != null ? head.remaining() : 1; | ||
| } | ||
| // Delegate ended but we still must write zstd frame epilogue (produced on close()). | ||
| if (upstreamEnded && !finished) { | ||
| // Return a positive value to keep the reactor calling produce(). | ||
| return OUT_BUF_DEFAULT; | ||
| } | ||
| return delegate.available(); | ||
| } | ||
|
|
||
| @Override | ||
| public void produce(final DataStreamChannel chan) throws IOException { | ||
| ensureStreamInitialized(); | ||
|
|
||
| // 1) flush anything already compressed | ||
| if (!flushPending(chan)) { | ||
| return; // back-pressure; we'll be called again | ||
| } | ||
| if (finished) { | ||
| return; | ||
| } | ||
|
|
||
| // 2) pull more input from delegate (this will drive compression via Inner.write) | ||
| delegate.produce(new Inner(chan)); | ||
|
|
||
| // 3) If upstream ended, finish the frame and drain everything | ||
| if (upstreamEnded && !finished) { | ||
| try { | ||
| zstream.close(); // triggers flushBuffer for remaining + frame trailer | ||
| } finally { | ||
| // fall through | ||
| } | ||
|
|
||
| if (!flushPending(chan)) { | ||
| // trailer not fully sent yet; wait for next turn | ||
| return; | ||
| } | ||
| finished = true; | ||
| chan.endStream(); | ||
| } | ||
| } | ||
|
|
||
| private void ensureStreamInitialized() throws IOException { | ||
| if (zstream != null) { | ||
| return; | ||
| } | ||
| // Create the compressor; override flushBuffer to queue full buffers. | ||
| zstream = new ZstdDirectBufferCompressingStream(outBuf, level) { | ||
| @Override | ||
| protected ByteBuffer flushBuffer(final ByteBuffer toFlush) throws IOException { | ||
| toFlush.flip(); | ||
| if (toFlush.hasRemaining()) { | ||
| pending.addLast(toFlush); // queue for network write | ||
| } | ||
| // hand a fresh direct buffer back to the compressor | ||
| outBuf = ByteBuffer.allocateDirect(outCap); | ||
| return outBuf; | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Try to write as much of the pending compressed data as the channel accepts. | ||
| */ | ||
| private boolean flushPending(final DataStreamChannel chan) throws IOException { | ||
| while (!pending.isEmpty()) { | ||
| final ByteBuffer head = pending.peekFirst(); | ||
| while (head.hasRemaining()) { | ||
| final int n = chan.write(head); | ||
| if (n == 0) { | ||
| // back-pressure: ask to be called again | ||
| chan.requestOutput(); | ||
| return false; | ||
| } | ||
| } | ||
| pending.removeFirst(); // this buffer fully sent | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| /** | ||
| * Compress the bytes in {@code src} (may be heap or direct). | ||
| */ | ||
| private int compressFrom(final ByteBuffer src) throws IOException { | ||
| final int before = src.remaining(); | ||
| if (src.isDirect()) { | ||
| zstream.compress(src); | ||
| } else { | ||
| // Stage heap → direct in chunks | ||
| while (src.hasRemaining()) { | ||
| inDirect.compact(); | ||
| final int take = Math.min(inDirect.remaining(), src.remaining()); | ||
| final int oldLimit = src.limit(); | ||
| src.limit(src.position() + take); | ||
| inDirect.put(src); | ||
| src.limit(oldLimit); | ||
| inDirect.flip(); | ||
| zstream.compress(inDirect); | ||
| } | ||
| } | ||
| // The compressor calls flushBuffer() as needed; new buffers are queued in 'pending'. | ||
| return before - src.remaining(); | ||
| } | ||
|
|
||
| private final class Inner implements DataStreamChannel { | ||
| private final DataStreamChannel downstream; | ||
|
|
||
| Inner(final DataStreamChannel downstream) { | ||
| this.downstream = downstream; | ||
| } | ||
|
|
||
| @Override | ||
| public void requestOutput() { | ||
| downstream.requestOutput(); | ||
| } | ||
|
|
||
| @Override | ||
| public int write(final ByteBuffer src) throws IOException { | ||
| final int consumed = compressFrom(src); | ||
| // Try to flush any buffers the compressor just queued | ||
| if (!flushPending(downstream)) { | ||
| // Not all data could be written now; ensure we get another callback | ||
| downstream.requestOutput(); | ||
| } | ||
| return consumed; | ||
| } | ||
|
|
||
| @Override | ||
| public void endStream() { | ||
| upstreamEnded = true; | ||
| // We will finalize and flush in the outer produce(); make sure it runs again soon. | ||
| downstream.requestOutput(); | ||
| } | ||
|
|
||
| @Override | ||
| public void endStream(final java.util.List<? extends Header> trailers) { | ||
| endStream(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void failed(final Exception cause) { | ||
| delegate.failed(cause); | ||
| } | ||
|
|
||
| @Override | ||
| public void releaseResources() { | ||
| if (released.compareAndSet(false, true)) { | ||
| try { | ||
| try { | ||
| if (zstream != null) { | ||
| zstream.close(); | ||
| } | ||
| } catch (final IOException ignore) { | ||
| } | ||
| } finally { | ||
| delegate.releaseResources(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initializing to default values creates clutter IMO.