Add Zstandardto async content compression #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...nt5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientZstdCompressionExample.java
Fixed
Show fixed
Hide fixed
| */ | ||
| private final ZstdDirectBufferCompressingStream zstream; | ||
|
|
||
| private volatile boolean upstreamEnded = false; |
Member
There was a problem hiding this comment.
Initializing to default values creates clutter IMO.
ok2c
reviewed
Aug 11, 2025
arturobernalg
force-pushed
the
aasync-transparent-content-decompression-zstd
branch
from
d9ec312 to
d872969
Compare
arturobernalg
force-pushed
the
aasync-transparent-content-decompression-zstd
branch
3 times, most recently
from
2f61f39 to
4fef0bb
Compare
ok2c
requested changes
Aug 15, 2025
...ent5/src/main/java/org/apache/hc/client5/http/async/methods/DeflatingZstdEntityProducer.java
Outdated
Show resolved
Hide resolved
...client5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java
Outdated
Show resolved
Hide resolved
...client5/src/main/java/org/apache/hc/client5/http/impl/async/ContentCompressionAsyncExec.java
Outdated
Show resolved
Hide resolved
arturobernalg
force-pushed
the
aasync-transparent-content-decompression-zstd
branch
from
1d8266f to
7ade7d7
Compare
Member
Author
|
@ok2c please do another pass. |
ok2c
reviewed
Aug 16, 2025
pom.xml
Outdated
| <groupId>com.github.luben</groupId> | ||
| <artifactId>zstd-jni</artifactId> | ||
| <version>${zstd.jni.version}</version> | ||
| <optional>true</optional> |
Member
There was a problem hiding this comment.
@arturobernalg This is unnecessary in the dependency management section.
ok2c
approved these changes
Aug 16, 2025
Wire InflatingZstdDataConsumer; add DeflatingZstdEntityProducer for streaming requests
arturobernalg
force-pushed
the
aasync-transparent-content-decompression-zstd
branch
from
26fe12f to
2d8d387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds transparent zstd response decoding via
ContentCompressionAsyncExec(InflatingZstdDataConsumer).Provides
DeflatingZstdEntityProducerfor streaming request compression.Examples:
AsyncClientServerZstdExample+AsyncClientZstdCompressionExample;