Skip to content

feat(go): improve test coverage for int slice primitive serializers #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrianLii wants to merge 1 commit into
base: main
Choose a base branch
from
+350 −0
Open

feat(go): improve test coverage for int slice primitive serializers #3313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
350 changes: 350 additions & 0 deletions go/fory/slice_primitive_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
package fory

import (
"math"
"strconv"
"testing"

"github.com/apache/fory/go/fory/float16"
Expand Down Expand Up @@ -65,3 +67,351 @@ func TestFloat16Slice(t *testing.T) {
assert.Nil(t, result)
})
}

func TestIntSlice(t *testing.T) {
f := NewFory()

t.Run("int_slice_large_numbers", func(t *testing.T) {
slice := []int{1, -2, 3, -4, 2147483647, -2147483648} // Example with large int32 values
if strconv.IntSize == 64 {
slice = []int{1, -2, 3, -4, math.MaxInt64, math.MinInt64} // For int64
Copy link
Collaborator

@chaokunyang chaokunyang Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using math.MaxInt64/math.MinInt64 in a []int literal and math.MaxUint64 in a []uint literal still overflows at compile time on 32-bit targets (for example GOARCH=386), even with the IntSize runtime guard. Please switch these literals to arch-sized bounds (math.MaxInt, math.MinInt, math.MaxUint) or build the 64-bit cases without overflowing constants.

}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("int_slice_empty", func(t *testing.T) {
slice := []int{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("int_slice_nil", func(t *testing.T) {
var slice []int = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestUintSlice(t *testing.T) {
f := NewFory()

t.Run("uint_slice_large_numbers", func(t *testing.T) {
slice := []uint{1, 2, 3, 4, 4294967295} // Example with large uint32 values
if strconv.IntSize == 64 {
slice = []uint{1, 2, 3, 4, math.MaxUint64} // For uint64
}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("uint_slice_empty", func(t *testing.T) {
slice := []uint{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("uint_slice_nil", func(t *testing.T) {
var slice []uint = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestInt8Slice(t *testing.T) {
f := NewFory()

t.Run("int8_slice_large_numbers", func(t *testing.T) {
slice := []int8{1, -2, 3, -4, math.MaxInt8, math.MinInt8}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int8
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("int8_slice_empty", func(t *testing.T) {
slice := []int8{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int8
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("int8_slice_nil", func(t *testing.T) {
var slice []int8 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int8
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestInt16Slice(t *testing.T) {
f := NewFory()

t.Run("int16_slice_large_numbers", func(t *testing.T) {
slice := []int16{1, -2, 3, -4, math.MaxInt16, math.MinInt16}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("int16_slice_empty", func(t *testing.T) {
slice := []int16{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("int16_slice_nil", func(t *testing.T) {
var slice []int16 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestInt32Slice(t *testing.T) {
f := NewFory()

t.Run("int32_slice_large_numbers", func(t *testing.T) {
slice := []int32{1, -2, 3, -4, math.MaxInt32, math.MinInt32}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("int32_slice_empty", func(t *testing.T) {
slice := []int32{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("int32_slice_nil", func(t *testing.T) {
var slice []int32 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestInt64Slice(t *testing.T) {
f := NewFory()

t.Run("int64_slice_large_numbers", func(t *testing.T) {
slice := []int64{1, -2, 3, -4, math.MaxInt64, math.MinInt64}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("int64_slice_empty", func(t *testing.T) {
slice := []int64{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("int64_slice_nil", func(t *testing.T) {
var slice []int64 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []int64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestUint16Slice(t *testing.T) {
f := NewFory()

t.Run("uint16_slice_large_numbers", func(t *testing.T) {
slice := []uint16{1, 2, 3, 4, math.MaxUint16}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("uint16_slice_empty", func(t *testing.T) {
slice := []uint16{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("uint16_slice_nil", func(t *testing.T) {
var slice []uint16 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint16
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestUint32Slice(t *testing.T) {
f := NewFory()

t.Run("uint32_slice_large_numbers", func(t *testing.T) {
slice := []uint32{1, 2, 3, 4, math.MaxUint32}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("uint32_slice_empty", func(t *testing.T) {
slice := []uint32{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("uint32_slice_nil", func(t *testing.T) {
var slice []uint32 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint32
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}

func TestUint64Slice(t *testing.T) {
f := NewFory()

t.Run("uint64_slice_large_numbers", func(t *testing.T) {
slice := []uint64{1, 2, 3, 4, math.MaxUint64}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Equal(t, slice, result)
})

t.Run("uint64_slice_empty", func(t *testing.T) {
slice := []uint64{}
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.NotNil(t, result)
assert.Empty(t, result)
})

t.Run("uint64_slice_nil", func(t *testing.T) {
var slice []uint64 = nil
data, err := f.Serialize(slice)
assert.NoError(t, err)

var result []uint64
err = f.Deserialize(data, &result)
assert.NoError(t, err)
assert.Nil(t, result)
})
}
Loading