feat(go): improve test coverage for int slice primitive serializers #3313
+350
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
reviewed
Feb 10, 2026
| t.Run("int_slice_large_numbers", func(t *testing.T) { | ||
| slice := []int{1, -2, 3, -4, 2147483647, -2147483648} // Example with large int32 values | ||
| if strconv.IntSize == 64 { | ||
| slice = []int{1, -2, 3, -4, math.MaxInt64, math.MinInt64} // For int64 |
Collaborator
There was a problem hiding this comment.
Using math.MaxInt64/math.MinInt64 in a []int literal and math.MaxUint64 in a []uint literal still overflows at compile time on 32-bit targets (for example GOARCH=386), even with the IntSize runtime guard. Please switch these literals to arch-sized bounds (math.MaxInt, math.MinInt, math.MaxUint) or build the 64-bit cases without overflowing constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Improve test coverage and robustness for Go int slice primitive serializers.
What does this PR do?
Added new test cases for
int,uint,int8,int16,int32,int64,uint16,uint32,uint64slice serializers ingo/fory/slice_primitive_test.go. Tests include large number serialization/deserialization scenarios.Related issues
@chaokunyang in #3311 (comment)
Does this PR introduce any user-facing change?