Skip to content

fix: strip trailing null bytes from pbxproj before parsing #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yocontra wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

fix: strip trailing null bytes from pbxproj before parsing #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/parseJob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ var fs = require('fs'),

try {
fileContents = fs.readFileSync(path, 'utf-8');
// Strip trailing null bytes that can appear from filesystem-level padding
// (e.g. Bun runtime file writes on APFS). The PEG parser rejects \0 characters.
fileContents = fileContents.replace(/\0+$/, '');
obj = parser.parse(fileContents);
process.send(obj);
} catch (e) {
Expand Down
4 changes: 4 additions & 0 deletions lib/pbxProject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ pbxProject.prototype.parse = function(cb) {
pbxProject.prototype.parseSync = function() {
var file_contents = fs.readFileSync(this.filepath, 'utf-8');

// Strip trailing null bytes that can appear from filesystem-level padding
// (e.g. Bun runtime file writes on APFS). The PEG parser rejects \0 characters.
file_contents = file_contents.replace(/\0+$/, '');

this.hash = parser.parse(file_contents);
return this;
}
Expand Down