fix: strip trailing null bytes from pbxproj before parsing#149
Open
yocontra wants to merge 1 commit intoapache:masterfrom
Open
fix: strip trailing null bytes from pbxproj before parsing#149yocontra wants to merge 1 commit intoapache:masterfrom
yocontra wants to merge 1 commit intoapache:masterfrom
Conversation
Some runtimes (notably Bun) and filesystems (APFS) can produce files with trailing null byte padding. The PEG parser rejects \0 characters, causing a SyntaxError even though the actual pbxproj content is valid. Strip trailing null bytes before passing file contents to the parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some runtimes (notably Bun) and filesystems (APFS) can produce files with trailing null byte padding after
fs.writeFileSync. When thexcodelibrary reads a.pbxprojfile that has been written this way, the PEG parser fails with:The actual pbxproj content is valid — only trailing
\0bytes cause the parse failure.Changes
lib/pbxProject.js(parseSync): Strip trailing null bytes before passing to parserlib/parseJob.js(asyncparse): Same fix for the forked worker pathThe fix is a single
.replace(/\0+$/, '')on the file contents string, applied afterreadFileSyncand beforeparser.parse().Reproduction
bun expo prebuild --platform ios --clean)withXcodeProjectwhich triggersparseSyncproject.pbxprojhas ~16KB of trailing null bytesSyntaxError: Expected end of input but "\0" foundTest plan