Skip to content

Camel-JBang: Propagate --java-version option to jbang run/debug comm…#22196

Merged
gnodet merged 1 commit intoapache:mainfrom
smongiar:fix-jbang-run-java-version
Mar 23, 2026
Merged

Camel-JBang: Propagate --java-version option to jbang run/debug comm…#22196
gnodet merged 1 commit intoapache:mainfrom
smongiar:fix-jbang-run-java-version

Conversation

@smongiar
Copy link
Contributor

…ands

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions bot added the dsl label Mar 23, 2026
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code on behalf of Guillaume Nodet

Thanks for the fix! One suggestion: the --java-version option in Run.java is missing the completionCandidates attribute that ExportBaseCommand already uses. Could you align it so tab completion works for camel run as well?

@CommandLine.Option(names = { "--java-version" }, completionCandidates = JavaVersionCompletionCandidates.class,
                    description = "Java version (${COMPLETION-CANDIDATES})", defaultValue = "21")

We can provide the change if needed.

@smongiar smongiar force-pushed the fix-jbang-run-java-version branch from dbd6cae to e9b8662 Compare March 23, 2026 17:23
@smongiar
Copy link
Contributor Author

Claude Code on behalf of Guillaume Nodet

Thanks for the fix! One suggestion: the --java-version option in Run.java is missing the completionCandidates attribute that ExportBaseCommand already uses. Could you align it so tab completion works for camel run as well?

@CommandLine.Option(names = { "--java-version" }, completionCandidates = JavaVersionCompletionCandidates.class,
                    description = "Java version (${COMPLETION-CANDIDATES})", defaultValue = "21")

We can provide the change if needed.

Done, thank you for the review

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code on behalf of Guillaume Nodet

LGTM, thanks for adding the completionCandidates!

@gnodet
Copy link
Contributor

gnodet commented Mar 23, 2026

Created CAMEL-23235 for this fix.

-- Claude Code on behalf of Guillaume Nodet

@gnodet gnodet merged commit c00319b into apache:main Mar 23, 2026
5 checks passed
gnodet added a commit to JiriOndrusek/camel that referenced this pull request Mar 24, 2026
…letion candidates

- Resolve merge conflicts with apache#22196 (completionCandidates)
- Remove duplicate eq.javaVersion assignments in runQuarkus() and runSpringBoot()
- Add "17" to JavaVersionCompletionCandidates

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants