Camel-JBang: Propagate --java-version option to jbang run/debug comm…#22196
Camel-JBang: Propagate --java-version option to jbang run/debug comm…#22196gnodet merged 1 commit intoapache:mainfrom
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
left a comment
There was a problem hiding this comment.
Claude Code on behalf of Guillaume Nodet
Thanks for the fix! One suggestion: the --java-version option in Run.java is missing the completionCandidates attribute that ExportBaseCommand already uses. Could you align it so tab completion works for camel run as well?
@CommandLine.Option(names = { "--java-version" }, completionCandidates = JavaVersionCompletionCandidates.class,
description = "Java version (${COMPLETION-CANDIDATES})", defaultValue = "21")We can provide the change if needed.
dbd6cae to
e9b8662
Compare
Done, thank you for the review |
gnodet
left a comment
There was a problem hiding this comment.
Claude Code on behalf of Guillaume Nodet
LGTM, thanks for adding the completionCandidates!
|
Created CAMEL-23235 for this fix. -- Claude Code on behalf of Guillaume Nodet |
…letion candidates - Resolve merge conflicts with apache#22196 (completionCandidates) - Remove duplicate eq.javaVersion assignments in runQuarkus() and runSpringBoot() - Add "17" to JavaVersionCompletionCandidates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ands
Target
mainbranch)