Camel-jbang - adds target java version of exported app (during RUN)#22071
Open
JiriOndrusek wants to merge 3 commits intoapache:mainfrom
Open
Camel-jbang - adds target java version of exported app (during RUN)#22071JiriOndrusek wants to merge 3 commits intoapache:mainfrom
JiriOndrusek wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…letion candidates - Resolve merge conflicts with apache#22196 (completionCandidates) - Remove duplicate eq.javaVersion assignments in runQuarkus() and runSpringBoot() - Add "17" to JavaVersionCompletionCandidates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
reviewed
Mar 24, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Claude Code on behalf of Guillaume Nodet
I've merged main into the branch and resolved the merge conflicts with #22196 (completionCandidates). I also fixed:
- Duplicate
eq.javaVersionassignments — bothrunQuarkus()andrunSpringBoot()had the field set twice (once from the PR, once from the merge with #22196). Removed the duplicates. - Added "17" to
JavaVersionCompletionCandidates— the PR's intent to support Java 17 needs to be reflected in the completion candidates (added by #22196), not just in the description string.
Remaining items that need attention:
- Annotation style inconsistency: The new option in
Run.javauses@CommandLine.Optionwhile most other options in the same file use the imported short form@Option - No tests: No tests verify the
--java-versionoption is parsed and propagated fromRunto the export commands - Generated files:
camel-jbang-commands-metadata.jsonand docs need regeneration after adding the new option toRun
Contributor
Author
|
The remaining items were addressed in the latest commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://issues.apache.org/jira/browse/CAMEL-23208
Adds an option to specify java version for RUN command, so the exported app will use it (this is required to be able to execute RUN with java 17)
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.