Skip to content

Camel-jbang - adds target java version of exported app (during RUN)#22071

Open
JiriOndrusek wants to merge 3 commits intoapache:mainfrom
JiriOndrusek:camel-jbang-run-custom-java
Open

Camel-jbang - adds target java version of exported app (during RUN)#22071
JiriOndrusek wants to merge 3 commits intoapache:mainfrom
JiriOndrusek:camel-jbang-run-custom-java

Conversation

@JiriOndrusek
Copy link
Contributor

fixes https://issues.apache.org/jira/browse/CAMEL-23208

Adds an option to specify java version for RUN command, so the exported app will use it (this is required to be able to execute RUN with java 17)

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions bot added the dsl label Mar 18, 2026
…letion candidates

- Resolve merge conflicts with apache#22196 (completionCandidates)
- Remove duplicate eq.javaVersion assignments in runQuarkus() and runSpringBoot()
- Add "17" to JavaVersionCompletionCandidates

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the docs label Mar 24, 2026
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code on behalf of Guillaume Nodet

I've merged main into the branch and resolved the merge conflicts with #22196 (completionCandidates). I also fixed:

  1. Duplicate eq.javaVersion assignments — both runQuarkus() and runSpringBoot() had the field set twice (once from the PR, once from the merge with #22196). Removed the duplicates.
  2. Added "17" to JavaVersionCompletionCandidates — the PR's intent to support Java 17 needs to be reflected in the completion candidates (added by #22196), not just in the description string.

Remaining items that need attention:

  • Annotation style inconsistency: The new option in Run.java uses @CommandLine.Option while most other options in the same file use the imported short form @Option
  • No tests: No tests verify the --java-version option is parsed and propagated from Run to the export commands
  • Generated files: camel-jbang-commands-metadata.json and docs need regeneration after adding the new option to Run

@JiriOndrusek
Copy link
Contributor Author

The remaining items were addressed in the latest commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants