[Iceberg] pin hadoop to 3.3.6#38500
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues introduced by recent upgrades to shaded bigdataoss libraries. By pinning the Hadoop version to 3.3.6, the changes resolve dependency conflicts that were causing Iceberg HadoopFileIO read operations to fail. This is a temporary workaround until downstream dependencies like parquet-hadoop update their support for newer Hadoop versions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request pins Hadoop dependencies to version 3.3.6 in the Iceberg IO module to resolve version conflicts and updates IcebergScanConfig to use Guava's Sets utility instead of Hadoop's. A review comment suggests defining a local variable for the Hadoop version in the build script to improve maintainability and prevent potential version mismatches.
| resolutionStrategy.force 'org.apache.hadoop:hadoop-common:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6' |
There was a problem hiding this comment.
The Hadoop version 3.3.6 is hardcoded in multiple places within this file (lines 62, 124, 125, 126, and 127). To improve maintainability and prevent potential version mismatches during future updates, it is recommended to define a local variable for the Hadoop version and reuse it throughout the script.
def hadoopVersion = "3.3.6"
resolutionStrategy.force "org.apache.hadoop:hadoop-common:$hadoopVersion"
resolutionStrategy.force "org.apache.hadoop:hadoop-client:$hadoopVersion"
resolutionStrategy.force "org.apache.hadoop:hadoop-hdfs:$hadoopVersion"
resolutionStrategy.force "org.apache.hadoop:hadoop-hdfs-client:$hadoopVersion"
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
* pin hadoop to 3.3.6 * pin in expansion service too
| // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with global hadoop-common:3.4.2 | ||
| // upgrading gcs-connector to 4.0.0 would be fine, because it uses hadoop-common 3.4.2 | ||
| // but parquet-hadoop is still at 3.3.0 | ||
| // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a version that uses hadoop 3.4.2+ |
There was a problem hiding this comment.
Fly by: Is there an ETA for removing this ? Probably let's create a Github issue to track and add here.
We upgraded some shaded bigdataoss libraries in #38419, and they now bring in hadoop 3x libraries. Some of these libraries conflict with existing hadoop-common 3.4.2 as well as parquet-hadoop (1.16.0)
This causes Iceberg HadoopFileIO read operations to fail with the following exceptions:
gcs-connector has a newer version (4.0.0+) that pulls in 3.4.2 and would work fine, but parquet-hadoop is still stuck at 3.3.0, so the only workaround is to pin our hadoop version to 3.3.6 for now.
Fixes #34962
Fixes #34809
Fixes #31931
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.