Skip to content

[Iceberg] pin hadoop to 3.3.6#38500

Merged
Abacn merged 2 commits into
apache:masterfrom
ahmedabu98:pin_iceberg_hadoop
May 14, 2026
Merged

[Iceberg] pin hadoop to 3.3.6#38500
Abacn merged 2 commits into
apache:masterfrom
ahmedabu98:pin_iceberg_hadoop

Conversation

@ahmedabu98
Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 commented May 14, 2026

We upgraded some shaded bigdataoss libraries in #38419, and they now bring in hadoop 3x libraries. Some of these libraries conflict with existing hadoop-common 3.4.2 as well as parquet-hadoop (1.16.0)

This causes Iceberg HadoopFileIO read operations to fail with the following exceptions:

java.lang.NoSuchMethodError: 'void org.apache.hadoop.fs.VectoredReadUtils.validateRangeRequest(org.apache.hadoop.fs.FileRange)'
java.lang.RuntimeException: java.lang.NoSuchMethodError: 'void org.apache.hadoop.fs.VectoredReadUtils.validateRangeRequest(org.apache.hadoop.fs.FileRange)'
	at org.apache.parquet.util.DynMethods$UnboundMethod.invokeChecked(DynMethods.java:67)
	at org.apache.parquet.hadoop.util.wrapped.io.VectorIoBridge.readWrappedRanges(VectorIoBridge.java:244)
	at org.apache.parquet.hadoop.util.wrapped.io.VectorIoBridge.readVectoredRanges(VectorIoBridge.java:201)
	at org.apache.parquet.hadoop.util.H1SeekableInputStream.readVectored(H1SeekableInputStream.java:75)
	at org.apache.parquet.hadoop.ParquetFileReader.readVectored(ParquetFileReader.java:1357)
	at org.apache.parquet.hadoop.ParquetFileReader.readAllPartsVectoredOrNormal(ParquetFileReader.java:1274)
	at org.apache.parquet.hadoop.ParquetFileReader.internalReadRowGroup(ParquetFileReader.java:1185)
	at org.apache.parquet.hadoop.ParquetFileReader.readNextRowGroup(ParquetFileReader.java:1135)
	at org.apache.iceberg.parquet.ParquetReader$FileIterator.advance(ParquetReader.java:161)
	at org.apache.iceberg.parquet.ParquetReader$FileIterator.next(ParquetReader.java:130)
	at org.apache.iceberg.io.FilterIterator.advance(FilterIterator.java:65)
	at org.apache.iceberg.io.FilterIterator.hasNext(FilterIterator.java:49)
	at org.apache.beam.sdk.io.iceberg.ScanTaskReader.advance(ScanTaskReader.java:102)
	at org.apache.beam.sdk.io.iceberg.ScanTaskReader.start(ScanTaskReader.java:84)

gcs-connector has a newer version (4.0.0+) that pulls in 3.4.2 and would work fine, but parquet-hadoop is still stuck at 3.3.0, so the only workaround is to pin our hadoop version to 3.3.6 for now.

Fixes #34962
Fixes #34809
Fixes #31931


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues introduced by recent upgrades to shaded bigdataoss libraries. By pinning the Hadoop version to 3.3.6, the changes resolve dependency conflicts that were causing Iceberg HadoopFileIO read operations to fail. This is a temporary workaround until downstream dependencies like parquet-hadoop update their support for newer Hadoop versions.

Highlights

  • Hadoop Version Pinning: Pinned Hadoop dependencies to version 3.3.6 to resolve runtime NoSuchMethodError exceptions caused by library conflicts between bigdataoss and parquet-hadoop.
  • Dependency Resolution Strategy: Updated the Gradle configuration to force specific Hadoop components (common, client, hdfs, hdfs-client) to version 3.3.6.
  • Code Cleanup: Corrected an incorrect import in IcebergScanConfig.java to use the vendor-provided Guava Sets utility instead of a Hadoop-internal one.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request pins Hadoop dependencies to version 3.3.6 in the Iceberg IO module to resolve version conflicts and updates IcebergScanConfig to use Guava's Sets utility instead of Hadoop's. A review comment suggests defining a local variable for the Hadoop version in the build script to improve maintainability and prevent potential version mismatches.

Comment on lines +124 to +127
resolutionStrategy.force 'org.apache.hadoop:hadoop-common:3.3.6'
resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6'
resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6'
resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Hadoop version 3.3.6 is hardcoded in multiple places within this file (lines 62, 124, 125, 126, and 127). To improve maintainability and prevent potential version mismatches during future updates, it is recommended to define a local variable for the Hadoop version and reuse it throughout the script.

  def hadoopVersion = "3.3.6"
  resolutionStrategy.force "org.apache.hadoop:hadoop-common:$hadoopVersion"
  resolutionStrategy.force "org.apache.hadoop:hadoop-client:$hadoopVersion"
  resolutionStrategy.force "org.apache.hadoop:hadoop-hdfs:$hadoopVersion"
  resolutionStrategy.force "org.apache.hadoop:hadoop-hdfs-client:$hadoopVersion"

Comment thread sdks/java/io/iceberg/build.gradle
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @Abacn for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 9a1a4b1 into apache:master May 14, 2026
25 checks passed
Amar3tto pushed a commit that referenced this pull request May 14, 2026
* pin hadoop to 3.3.6

* pin in expansion service too
Amar3tto added a commit that referenced this pull request May 14, 2026
Cherry-pick #38488 and #38500 into release branch
// bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with global hadoop-common:3.4.2
// upgrading gcs-connector to 4.0.0 would be fine, because it uses hadoop-common 3.4.2
// but parquet-hadoop is still at 3.3.0
// so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a version that uses hadoop 3.4.2+
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fly by: Is there an ETA for removing this ? Probably let's create a Github issue to track and add here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #38517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants