CherryPick: Fix Iceberg hadoopIO dep failure#38502
Conversation
|
R: @Amar3tto |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses dependency conflicts related to Hadoop versions within the Iceberg IO and expansion service modules. By pinning Hadoop to version 3.3.6, the changes ensure compatibility between conflicting libraries while maintaining stability. Additionally, the PR includes minor code refactoring to improve dependency isolation and updates test triggers to verify the fix. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request pins Hadoop dependencies to version 3.3.6 in the Iceberg and expansion-service modules to resolve version conflicts between gcs-connector and parquet-hadoop. It also updates an import in IcebergScanConfig to use vendor-shaded Guava and adds a necessary runtime dependency. Feedback focuses on improving maintainability by centralizing the Hadoop version variable and maintaining consistency in how dependencies are referenced in the build files.
| implementation "org.apache.iceberg:iceberg-orc:$iceberg_version" | ||
| implementation "org.apache.iceberg:iceberg-data:$iceberg_version" | ||
| implementation library.java.hadoop_common | ||
| implementation "org.apache.hadoop:hadoop-common:3.3.6" |
There was a problem hiding this comment.
The dependency hadoop-common is hardcoded to version 3.3.6 here, while hadoop_client on line 74 continues to use the library.java catalog. Since resolutionStrategy.force is applied later in this file (lines 125-128) to ensure version 3.3.6 is used across all configurations, it is more consistent and maintainable to keep using the library catalog here.
implementation library.java.hadoop_common
| // [iceberg] | ||
| // bigdataoss:gcs-connector and parquet:parquet-hadoop have conflicts with global hadoop-common:3.4.2 | ||
| // upgrading gcs-connector to 4.0.0 would be fine, because it uses hadoop-common 3.4.2 | ||
| // but parquet-hadoop is still at 3.3.0 | ||
| // so for now we need to pin hadoop to 3.3.6 until parquet-hadoop releases a version that uses hadoop 3.4.2+ | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-common:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-client:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs:3.3.6' | ||
| resolutionStrategy.force 'org.apache.hadoop:hadoop-hdfs-client:3.3.6' |
There was a problem hiding this comment.
This block of version pinning and the accompanying comment are duplicated in sdks/java/io/iceberg/build.gradle. To improve maintainability and ensure that this temporary override is managed in one place, consider defining the Hadoop version as a variable in a central location (e.g., BeamModulePlugin or a project-level property) and referencing it in both files.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
CP for #38500
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.