Skip to content

fix interactive environment circular import #37147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunping merged 2 commits into from
Dec 18, 2025
Merged

fix interactive environment circular import #37147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d37c808
fix interactive enviornemnt circular import
derrickaw Dec 18, 2025
f198c11
remove unnecessary protection for circular import
derrickaw Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdks/python/apache_beam/runners/interactive/interactive_environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
from apache_beam.runners.direct import direct_runner
from apache_beam.runners.interactive import cache_manager as cache
from apache_beam.runners.interactive.messaging.interactive_environment_inspector import InteractiveEnvironmentInspector
from apache_beam.runners.interactive.recording_manager import RecordingManager
from apache_beam.runners.interactive.sql.sql_chain import SqlChain
from apache_beam.runners.interactive.user_pipeline_tracker import UserPipelineTracker
from apache_beam.runners.interactive.utils import assert_bucket_exists
Expand Down Expand Up @@ -428,6 +427,10 @@ def set_recording_manager(self, recording_manager, pipeline):

def get_recording_manager(self, pipeline, create_if_absent=False):
"""Gets the recording manager for the given pipeline."""
# Allow initial module loading to be complete and not have a circular
# import.
from apache_beam.runners.interactive.recording_manager import RecordingManager

recording_manager = self._recording_managers.get(str(id(pipeline)), None)
if not recording_manager and create_if_absent:
# Get the pipeline variable name for the user. This is useful if the user
Expand Down
5 changes: 1 addition & 4 deletions sdks/python/apache_beam/runners/interactive/recording_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
from apache_beam.runners.interactive import pipeline_fragment as pf
from apache_beam.runners.interactive import utils
from apache_beam.runners.interactive.caching.cacheable import CacheKey
from apache_beam.runners.interactive.display.pipeline_graph import PipelineGraph
from apache_beam.runners.interactive.options import capture_control
from apache_beam.runners.runner import PipelineState

Expand Down Expand Up @@ -712,10 +713,6 @@ def _get_pipeline_graph(self):
"""Lazily initializes and returns the PipelineGraph."""
if self._pipeline_graph is None:
try:
# Allow initial module loading to be complete and not have a circular
# import.
from apache_beam.runners.interactive.display.pipeline_graph import PipelineGraph

# Try to create the graph.
self._pipeline_graph = PipelineGraph(self.user_pipeline)
except (ImportError, NameError, AttributeError):
Expand Down
Loading