fix interactive environment circular import

[derrickaw]

fix #37134 (comment)

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a circular dependency that was occurring in the interactive environment setup. By changing the RecordingManager import from a global to a local scope within the get_recording_manager function, the system can now properly initialize modules without encountering import cycle errors, leading to a more stable and reliable interactive experience.

Highlights

• Circular Import Resolution: The pull request addresses a circular import issue involving the RecordingManager within the interactive environment. The import statement for RecordingManager has been refactored to occur locally within the get_recording_manager method, rather than as a top-level module import.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[shunping]

I think now that you cut the direct dependency between interative_environment and RecordingManager, you can also safely revert your last commit: 8cc26a4

For your reference:

• First cicular deps: pipeline_graph -> interactive_environment -> RecordingManager -> pipeline_graph
  To reproduce:

  from apache_beam.runners.interactive.display import pipeline_graph

• Second cirular deps: RecordingManager -> background_caching_job -> interactive_environment -> RecordingManager
  To reproduce:

  from apache_beam.runners.interactive.recording_manager import RecordingManager

The current class structure is a bit cumbersome and susceptible to circular dependencies. We may need to open a papercut task to refactor it in the future.

[derrickaw]

Run Python_Runners PreCommit 3.10

[shunping]

LGTM! Thanks @derrickaw!