-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add new method of generating key for GBEK #36891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #36891 +/- ##
============================================
+ Coverage 55.07% 55.14% +0.07%
Complexity 1667 1667
============================================
Files 1063 1063
Lines 166396 166765 +369
Branches 1199 1199
============================================
+ Hits 91638 91963 +325
- Misses 72582 72626 +44
Partials 2176 2176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@damccorm What is the status for this? |
|
I think we should try to get this in if we can, it is a really important patch for making sure that our GBEK story is complete, and that is probably worth delaying the release a couple of days if needed. It still needs a review and I need to get the permissions right for GitHub Actions (this is the only thing causing suites to fail) |
|
R: @Abacn since I think you reviewed pieces of this initially. |
|
Feel free to ignore the failing permission causing test failures right now, that is caused by insufficiently a privileged GHA runner, in general tests are passing locally and I will address it before merging (should require no code changes) |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a pass for Java change, also submitted one review comment for Python because triggering Python tests may need time to iterate.
Will review Python change next, or find a second eyes for Python if needed.
sdks/java/core/src/main/java/org/apache/beam/sdk/util/Secret.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcpHsmGeneratedSecret.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/util/GcpHsmGeneratedSecret.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/GroupByKeyIT.java
Outdated
Show resolved
Hide resolved
| try: | ||
| from google.cloud import kms | ||
| except ImportError: | ||
| kms = None # type: ignore[assignment] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Python SDK we have this mechanism to handle optional dependency. Just wondering if it is possible to make gcp secret dependencies optional for Java core as well. Just a side note, not needed for this PR.
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Feel free to merge after PostCommit finishing
* Add new method of generating key for GBEK * Java version * fix deps * Imports * Secret parsing tests * docs * more docs * formatting + test cleanup * lint * lint * lint * lint * import order * Deps + style exemption * reuse key: * reuse key * Feedback * Test fixes
* Add new method of generating key for GBEK * Java version * fix deps * Imports * Secret parsing tests * docs * more docs * formatting + test cleanup * lint * lint * lint * lint * import order * Deps + style exemption * reuse key: * reuse key * Feedback * Test fixes
This will use the following process to introduce some extra entropy into the generated key:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.