[Cherry-pick] Add new method of generating key for GBEK (#36891)

[damccorm]

Original: #36891

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new, more secure method for generating keys within Apache Beam's Group By Encrypted Key (GBEK) feature. It introduces GcpHsmGeneratedSecret, which utilizes Google Cloud Key Management Service (KMS) with Hardware Security Modules (HSM) to generate cryptographic keys with enhanced entropy, and then securely stores these keys in Google Cloud Secret Manager. This provides a robust and auditable mechanism for managing sensitive keys required for data processing, improving the overall security posture of Beam pipelines.

Highlights

• New Key Generation Method: Introduced GcpHsmGeneratedSecret in both Java and Python SDKs, providing a new way to generate keys for Group By Encrypted Key (GBEK) functionality.
• Google Cloud KMS and Secret Manager Integration: The new key generation method leverages Google Cloud Key Management Service (KMS) with Hardware Security Modules (HSM) for enhanced entropy and securely stores the generated keys in Google Cloud Secret Manager.
• Extended Secret Parsing: The Secret parsing utility has been updated to recognize and handle the new gcphsmgeneratedsecret type, allowing pipelines to specify this secure key generation method.
• Comprehensive Testing: Added extensive unit and integration tests across both Java and Python SDKs to validate the functionality and robustness of the new HSM-backed secret generation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[damccorm]

R: @Amar3tto

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers