Skip to content

GH-49065: [C++] Remove unnecessary copies of shared_ptr in Type::BOOL and Type::NA at GrouperImpl #49066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Jan 30, 2026
+16 −15
Merged

GH-49065: [C++] Remove unnecessary copies of shared_ptr in Type::BOOL and Type::NA at GrouperImpl #49066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions cpp/src/arrow/compute/row/grouper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,43 +341,44 @@ struct GrouperImpl : public Grouper {
impl->ctx_ = ctx;

for (size_t i = 0; i < key_types.size(); ++i) {
// TODO(wesm): eliminate this probably unneeded shared_ptr copy
std::shared_ptr<DataType> key = key_types[i].GetSharedPtr();
const auto& key_type = key_types[i];

if (key->id() == Type::BOOL) {
if (key_type.id() == Type::BOOL) {
impl->encoders_[i] = std::make_unique<internal::BooleanKeyEncoder>();
continue;
}

if (key->id() == Type::DICTIONARY) {
impl->encoders_[i] =
std::make_unique<internal::DictionaryKeyEncoder>(key, ctx->memory_pool());
if (key_type.id() == Type::DICTIONARY) {
impl->encoders_[i] = std::make_unique<internal::DictionaryKeyEncoder>(
key_type.GetSharedPtr(), ctx->memory_pool());
continue;
}

if (is_fixed_width(key->id())) {
impl->encoders_[i] = std::make_unique<internal::FixedWidthKeyEncoder>(key);
if (is_fixed_width(key_type.id())) {
impl->encoders_[i] =
std::make_unique<internal::FixedWidthKeyEncoder>(key_type.GetSharedPtr());
continue;
}

if (is_binary_like(key->id())) {
impl->encoders_[i] =
std::make_unique<internal::VarLengthKeyEncoder<BinaryType>>(key);
if (is_binary_like(key_type.id())) {
impl->encoders_[i] = std::make_unique<internal::VarLengthKeyEncoder<BinaryType>>(
key_type.GetSharedPtr());
continue;
}

if (is_large_binary_like(key->id())) {
if (is_large_binary_like(key_type.id())) {
impl->encoders_[i] =
std::make_unique<internal::VarLengthKeyEncoder<LargeBinaryType>>(key);
std::make_unique<internal::VarLengthKeyEncoder<LargeBinaryType>>(
key_type.GetSharedPtr());
continue;
}

if (key->id() == Type::NA) {
if (key_type.id() == Type::NA) {
impl->encoders_[i] = std::make_unique<internal::NullKeyEncoder>();
continue;
}

return Status::NotImplemented("Keys of type ", *key);
return Status::NotImplemented("Keys of type ", *key_type);
}

return impl;
Expand Down
Loading