GH-49065: [C++] Remove unnecessary copies of shared_ptr in Type::BOOL and Type::NA at GrouperImpl #49066
+16
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The grouper code was creating a
shared_ptr<DataType>for every key type, even when it wasn't needed. This resulted in unnecessary reference counting operations. For example,BooleanKeyEncoderandNullKeyEncoderdon't require ashared_ptrin their constructors, yet we were creating one for every key of those types.What changes are included in this PR?
Changed
GrouperImpl::Make()to useTypeHolderreferences directly and only callGetSharedPtr()when needed by encoder constructors. This eliminatesshared_ptrcreation forType::BOOLandType::NAcases. Other encoder types (dictionary, fixed-width, binary) still requireshared_ptrsince their constructors takeshared_ptr<DataType>parameters for ownership.Are these changes tested?
Yes, existing tests.
Are there any user-facing changes?
No.