Skip to content

fix(@angular/ssr): ensure unique values in redirect response Vary header #32780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgp1130 merged 1 commit into from
Mar 17, 2026
Merged

fix(@angular/ssr): ensure unique values in redirect response Vary header #32780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/angular/ssr/src/utils/redirect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,18 @@ export function createRedirectResponse(
);
}

let vary = resHeaders.get('Vary') ?? '';
if (vary) {
vary += ', ';
// Ensure unique values for Vary header
const varyArray = resHeaders.get('Vary')?.split(',') ?? [];
const varySet = new Set(['X-Forwarded-Prefix']);
for (const vary of varyArray) {
const value = vary.trim();

if (value) {
varySet.add(value);
}
}
vary += 'X-Forwarded-Prefix';

resHeaders.set('Vary', vary);
resHeaders.set('Vary', [...varySet].join(', '));
resHeaders.set('Location', location);

return new Response(null, {
Expand Down
9 changes: 8 additions & 1 deletion packages/angular/ssr/test/utils/redirect_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,14 @@ describe('Redirect Utils', () => {
'Vary': 'Host',
});
expect(response.headers.get('Location')).toBe('/home');
expect(response.headers.get('Vary')).toBe('Host, X-Forwarded-Prefix');
expect(response.headers.get('Vary')).toBe('X-Forwarded-Prefix, Host');
});

it('should NOT add duplicate X-Forwarded-Prefix if already present in Vary header', () => {
const response = createRedirectResponse('/home', 302, {
'Vary': 'X-Forwarded-Prefix, Host',
});
expect(response.headers.get('Vary')).toBe('X-Forwarded-Prefix, Host');
});

it('should warn if Location header is provided in extra headers in dev mode', () => {
Expand Down
Loading