fix(@angular/ssr): ensure unique values in redirect response Vary header#32780
Merged
dgp1130 merged 1 commit intoangular:mainfrom Mar 17, 2026
Merged
fix(@angular/ssr): ensure unique values in redirect response Vary header#32780dgp1130 merged 1 commit intoangular:mainfrom
dgp1130 merged 1 commit intoangular:mainfrom
Conversation
Refactors the `createRedirectResponse` function to use a `Set` for constructing the `Vary` header. This ensures that `X-Forwarded-Prefix` is always present exactly once, and that existing `Vary` values from provided headers are correctly parsed, deduplicated, and preserved. Updates the associated unit tests to reflect the new header order and verify the deduplication logic.
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a potential issue with duplicate values in the Vary header for redirect responses by using a Set to ensure uniqueness. The logic is sound, and the accompanying unit tests effectively verify the fix, including the new deduplication behavior. I've provided one suggestion to make the implementation more concise using a more functional style, but the current approach is also perfectly valid.
dgp1130
approved these changes
Mar 17, 2026
alan-agius4
added
action: merge
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
createRedirectResponsefunction to use aSetfor constructing theVaryheader. This ensures thatX-Forwarded-Prefixis always present exactly once, and that existingVaryvalues from provided headers are correctly parsed, deduplicated, and preserved.Updates the associated unit tests to reflect the new header order and verify the deduplication logic.