fix(@schematics/angular): do not set esModuleInterop and moduleResolution when module is preserve

[Deku-nattsu]

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Migrating from v20 to v21 causes both esModuleInterop and moduleResolution to be added again which isn't needed when module is set to preserve

Does this PR introduce a breaking change?

• Yes
• No

Other information

[alan-agius4]

LGTM, just one NIT.

Would also be nice to add a test for this.

[Deku-nattsu]

LGTM, just one NIT.

Would also be nice to add a test for this.

okay i'll try

[Deku-nattsu]

i used the same setup in https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/migrations/update-module-resolution/migration_spec.ts#L109

[alan-agius4]

i used the same setup in https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/migrations/update-module-resolution/migration_spec.ts#L109

Interesting, probably that could be cleaned up a bit hahaha.

[alan-agius4]

LGTM, thanks for your contribution.

[dgp1130]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 50d9c0e
• 21.0.x: 4534c98

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}