fix(@schematics/angular): do not set esModuleInterop and moduleResolution when module is preserve

Author: Deku-nattsu

packages/schematics/angular/migrations/use-application-builder/migration.ts

@@ -362,10 +362,16 @@ export default function (): Rule {
     ),
     // Update main tsconfig
     updateJsonFile('tsconfig.json', (rootJson) => {
-      rootJson.modify(['compilerOptions', 'esModuleInterop'], true);
+      const module = rootJson.get(['compilerOptions', 'module']);
+      const hasPreserveModule = typeof module === 'string' && module.toLowerCase() === 'preserve';
+
+      if (!hasPreserveModule) {
+        rootJson.modify(['compilerOptions', 'esModuleInterop'], true);
+        rootJson.modify(['compilerOptions', 'moduleResolution'], 'bundler');
+      }
+
       rootJson.modify(['compilerOptions', 'downlevelIteration'], undefined);
       rootJson.modify(['compilerOptions', 'allowSyntheticDefaultImports'], undefined);
-      rootJson.modify(['compilerOptions', 'moduleResolution'], 'bundler');
     }),
   ]);
 }

packages/schematics/angular/migrations/use-application-builder/migration_spec.ts

@@ -6,6 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
+import { JsonObject } from '@angular-devkit/core';
 import { EmptyTree } from '@angular-devkit/schematics';
 import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
 import { Builders, ProjectType, WorkspaceSchema } from '../../utility/workspace-models';
@@ -448,4 +449,16 @@ describe(`Migration to use the application builder`, () => {
 
     expect(devDependencies['postcss']).toBeUndefined();
   });
+
+  it('it should not add esModuleInterop and moduleResolution when module is preserve', async () => {
+    tree.overwrite(
+      'tsconfig.json',
+      JSON.stringify({
+        compilerOptions: { module: 'preserve' },
+      }),
+    );
+    const newTree = await schematicRunner.runSchematic(schematicName, {}, tree);
+    const { compilerOptions } = newTree.readJson('tsconfig.json') as JsonObject;
+    expect(compilerOptions).toEqual({ module: 'preserve' });
+  });
 });