Fixes dev-setup.sh venv install and adds installation steps to README #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up.sh to avoid installation errors
dwiddows
requested review from
alexandraBara and
landrews-amd
as code owners
Collaborator
Author
|
Replacing this PR in favor of #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Moved to #59)
Fixes python3 -m pip install venv which fails saying:
ERROR: Could not find a version that satisfies the requirement venv (from versions: none)
ERROR: No matching distribution found for venv
This is changed to recommend sudo apt install python3-venv (but even that won't work on all platforms so suggested as a workaround, not implemented in the script).
The README is extended to explain the steps, some of which are optional (e.g. users don't need to install pre-commit hooks unless they use git commit).