Skip to content

fixing deprecated _fields_ #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandraBara merged 1 commit into from
Aug 4, 2025
Merged

fixing deprecated _fields_ #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions nodescraper/pluginexecutor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,26 @@ def apply_global_args_to_plugin(
else:
run_args[key] = global_args[key]

if "collection_args" in global_args and hasattr(plugin_class, "COLLECTOR_ARGS"):
plugin_fields = set(plugin_class.COLLECTOR_ARGS.__fields__.keys())
if (
"collection_args" in global_args
and hasattr(plugin_class, "COLLECTOR_ARGS")
and plugin_class.COLLECTOR_ARGS is not None
):

plugin_fields = set(plugin_class.COLLECTOR_ARGS.model_fields.keys())
filtered = {
k: v for k, v in global_args["collection_args"].items() if k in plugin_fields
}
if filtered:
run_args["collection_args"] = filtered

if "analysis_args" in global_args and hasattr(plugin_class, "ANALYZER_ARGS"):
plugin_fields = set(plugin_class.ANALYZER_ARGS.__fields__.keys())
if (
"analysis_args" in global_args
and hasattr(plugin_class, "ANALYZER_ARGS")
and plugin_class.ANALYZER_ARGS is not None
):

plugin_fields = set(plugin_class.ANALYZER_ARGS.model_fields.keys())
filtered = {k: v for k, v in global_args["analysis_args"].items() if k in plugin_fields}
if filtered:
run_args["analysis_args"] = filtered
Expand Down