Skip to content

Conversation

@alexandraBara
Copy link
Collaborator

@alexandraBara alexandraBara commented Jul 30, 2025

Fixed warning for deprecation on fields and inheritance issue that allows plugin.COLLECTION_ARGS to be None from inheritance.
Sample failure:

(venv) (base) [alexbara@TheraS02 node-scraper]$ node-scraper --plugin-config reference_config_globals2.py
  2025-07-31 09:02:41 CDT       INFO               nodescraper | Log path: ./scraper_logs_theras02_thera_amd_com_2025_07_31-09_02_41_AM
  2025-07-31 09:02:41 CDT       INFO               nodescraper | System Name: TheraS02.thera.amd.com
  2025-07-31 09:02:41 CDT       INFO               nodescraper | System SKU: None
  2025-07-31 09:02:41 CDT       INFO               nodescraper | System Platform: None
  2025-07-31 09:02:41 CDT       INFO               nodescraper | System location: SystemLocation.LOCAL
  2025-07-31 09:02:41 CDT       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args
  2025-07-31 09:02:41 CDT      ERROR               nodescraper | Unexpected exception when running plugin DimmPlugin: 'NoneType' object has no attribute '__fields__'
Traceback (most recent call last):
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 175, in run_queue
    global_run_args = self.apply_global_args_to_plugin(
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 255, in apply_global_args_to_plugin
    plugin_fields = set(plugin_class.ANALYZER_ARGS.__fields__.keys())
AttributeError: 'NoneType' object has no attribute '__fields__'
  2025-07-31 09:02:41 CDT      ERROR               nodescraper | Unexpected exception when running plugin StoragePlugin: 'NoneType' object has no attribute '__fields__'
Traceback (most recent call last):
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 175, in run_queue
    global_run_args = self.apply_global_args_to_plugin(
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 255, in apply_global_args_to_plugin
    plugin_fields = set(plugin_class.ANALYZER_ARGS.__fields__.keys())
AttributeError: 'NoneType' object has no attribute '__fields__'
  2025-07-31 09:02:41 CDT      ERROR               nodescraper | Unexpected exception when running plugin DmesgPlugin: 'NoneType' object has no attribute '__fields__'
Traceback (most recent call last):
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 175, in run_queue
    global_run_args = self.apply_global_args_to_plugin(
  File "/home/alexbara/node-scraper/nodescraper/pluginexecutor.py", line 255, in apply_global_args_to_plugin
    plugin_fields = set(plugin_class.ANALYZER_ARGS.__fields__.keys())
AttributeError: 'NoneType' object has no attribute '__fields__'
  2025-07-31 09:02:41 CDT       INFO               nodescraper | Closing connections
  2025-07-31 09:02:41 CDT       INFO               nodescraper | Running result collators
  2025-07-31 09:02:41 CDT       INFO               nodescraper | Running TableSummary result collator
  2025-07-31 09:02:41 CDT       INFO               nodescraper |

+-------------------------+--------+---------+
|  Connection              | Status | Message |
+-------------------------+--------+---------+
|  InBandConnectionManager | UNSET  |         |
+-------------------------+--------+---------+

  2025-07-31 09:02:41 CDT       INFO               nodescraper | Data written to csv file: ./scraper_logs_theras02_thera_amd_com_2025_07_31-09_02_41_AM/nodescraper.csv

Config file:

(venv) (base) [alexbara@TheraC60 node-scraper]$ cat reference_config_globals2.py
{
  "global_args": {
      "analysis_args": {
        "exp_bios_version": [
          "M17"
        ],
        "regex_match": false
      },
      "collection_args": {
        "skip_sudo" : 0
      },
      "max_event_priority_level" : 1,
      "system_interaction_level" : 1,
      "preserve_connection" : 1,
      "collection" : 1,
      "analysis" : 0
  },
  "plugins": {
    "DimmPlugin": {},
    "StoragePlugin": {},
    "DmesgPlugin": {}
  },
  "result_collators": {}
}

@alexandraBara alexandraBara merged commit 7eefee3 into development Aug 4, 2025
5 checks passed
@alexandraBara alexandraBara deleted the alex_deprecation_fix branch August 4, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants